[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread via cfe-commits
https://github.com/jkorous-apple closed https://github.com/llvm/llvm-project/pull/80787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread via cfe-commits
jkorous-apple wrote: > LGTM! I think I did something similar locally when I collected data of > unclaimed DREs on those big adopter projects. So I guess the data that we > used to find major missing patterns for fix-its is still valid. So, on one hand it's good that the data are

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 approved this pull request. LGTM! I think I did something similar locally when I collected data of unclaimed DREs on those big adopter projects. So I guess the data that we used to find major missing patterns for fix-its is still valid.

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread via cfe-commits
https://github.com/jkorous-apple updated https://github.com/llvm/llvm-project/pull/80787 >From bda722a50efe136255b997a25b1ef0cff16237ba Mon Sep 17 00:00:00 2001 From: Jan Korous Date: Mon, 5 Feb 2024 18:21:50 -0800 Subject: [PATCH] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread via cfe-commits
https://github.com/jkorous-apple updated https://github.com/llvm/llvm-project/pull/80787 >From 1abbea30614c299219391770431b8226b8f7a88a Mon Sep 17 00:00:00 2001 From: Jan Korous Date: Mon, 5 Feb 2024 18:21:50 -0800 Subject: [PATCH] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-06 Thread via cfe-commits
https://github.com/jkorous-apple updated https://github.com/llvm/llvm-project/pull/80787 >From e4d9594cbaa42866820a2872944939a3697b539f Mon Sep 17 00:00:00 2001 From: Jan Korous Date: Mon, 5 Feb 2024 18:21:50 -0800 Subject: [PATCH] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8f80df0f52c4294d23d0510b01be6d6491714058 90e7145fe0133828b4abc16730b9786fc68df8b9 --

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jkorous-apple) Changes Debug notes for unclaimed DeclRefExpr should report any DRE of an unsafe variable that is not covered by a Fixable (i. e. fixit for the particular AST pattern isn't implemented for whatever reason). Currently

[clang] [-Wunsafe-buffer-usage] Fix debug notes for unclaimed DREs (PR #80787)

2024-02-05 Thread via cfe-commits
https://github.com/jkorous-apple created https://github.com/llvm/llvm-project/pull/80787 Debug notes for unclaimed DeclRefExpr should report any DRE of an unsafe variable that is not covered by a Fixable (i. e. fixit for the particular AST pattern isn't implemented for whatever reason).