https://github.com/syzaara closed
https://github.com/llvm/llvm-project/pull/86840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mandlebug approved this pull request.
LGTM. Zaara pointed out offline that we can't rely on the input being sorted
despite this change because you can invoke the front end directly with an
argument list in unsorted order.
https://github.com/llvm/llvm-project/pull/86840
https://github.com/mandlebug commented:
It's unfortunate we have to ditch the StringSet because of the iteration order
since the semantics of the option are the same regardless of the order the
names are printed in.
Now that we are constructing the list in sorted order we should change
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Zaara Syeda (syzaara)
Changes
Failure with testcase toc-conf.c observed when building with
LLVM_REVERSE_ITERATION=ON.
Changing from using llvm::StringSet to std::setllvm:StringRef to ensure
iteration order is deterministic. Note: the
https://github.com/syzaara created
https://github.com/llvm/llvm-project/pull/86840
Failure with testcase toc-conf.c observed when building with
LLVM_REVERSE_ITERATION=ON.
Changing from using llvm::StringSet to std::set to ensure
iteration order is deterministic. Note: the functionality of the
