[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

haampie wrote: @yxsamliu can you land this? I cannot https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

haampie wrote: I believe Spack sets either `HIP_PATH` or `ROCM_PATH` for clang which is considered before the auto-detection removed in this PR. https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/haampie edited https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

yxsamliu wrote: > I'm going to wager that we can't just rip this out without the world > exploding, and these issues need to be addressed and not just drop the whole > thing. [haampie](https://github.com/haampie) is the maintainer of the HIP spack package. I assume it is safe to remove them b

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

arsenm wrote: I'm going to wager that we can't just rip this out without the world exploding, and these issues need to be addressed and not just drop the whole thing. https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-co

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/haampie edited https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/haampie edited https://github.com/llvm/llvm-project/pull/133263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang-driver Author: Harmen Stoppels (haampie) Changes There is special logic to detect the hip runtime when llvm is installed with Spack. It works by matching the install prefix of llvm against `llvm-amdgpu-*` followe

[clang] [AMDGPU] Remove detection of hip runtime for Spack (PR #133263)

https://github.com/haampie created https://github.com/llvm/llvm-project/pull/133263 There is special logic to detect the hip runtime when llvm is installed with Spack. It works by matching the install prefix of llvm against `llvm-amdgpu-*` followed by effectively globbing for ``` /../hip-x.y.z-