https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
I'm going to land this patch now to unblock other work on APINotes, but I'm
happy to address more review feedback post-merge.
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
egorzhdan wrote:
@compnerd I think I addressed all of your comments, let me know if this is good
to go!
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -52,49 +52,54 @@ static void applyNullability(Sema , Decl *D,
NullabilityKind Nullability,
if (!Metadata.IsActive)
return;
- auto IsModified = [&](Decl *D, QualType QT,
-NullabilityKind Nullability) -> bool {
+ auto GetModified =
+
@@ -0,0 +1,44 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: %clang_cc1 -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t/ModulesCache -fapinotes-modules -Wno-private-module
-fsyntax-only -I %S/Inputs/Headers -F %S/Inputs/Frameworks %s -verify
+
+// Test with Swift
@@ -0,0 +1,4 @@
+Name: SomeBrokenLib
+Functions:
+ - Name: do_something_with_pointers
+Nu llabilityOfRet: O
egorzhdan wrote:
Alright, I added a comment
https://github.com/llvm/llvm-project/pull/84773
___
@@ -638,15 +638,15 @@ ObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S,
PDecl->setInvalidDecl();
}
- ProcessDeclAttributes(S, PDecl, FD.D);
-
// Regardless of setter/getter attribute, we save the default getter/setter
// selector names in anticipation of
@@ -0,0 +1,6 @@
+// RUN: rm -rf %t
+// RUN: not %clang_cc1 -fsyntax-only -fapinotes %s -I
%S/Inputs/BrokenHeaders2 2>&1 | FileCheck %s
compnerd wrote:
Extra space after `-fapinotes`
https://github.com/llvm/llvm-project/pull/84773
@@ -0,0 +1 @@
+extern int TopLevelPrivateKit_Public;
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,2 @@
+#include
+extern int FrameworkWithActualPrivateModule_Private;
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1 @@
+extern int FrameworkWithWrongCase;
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,55 @@
+#ifndef SOMEKIT_H
+#define SOMEKIT_H
+
+#define ROOT_CLASS __attribute__((objc_root_class))
+
+ROOT_CLASS
+@interface A
+-(A*)transform:(A*)input;
+-(A*)transform:(A*)input integer:(int)integer;
+
+@property (nonatomic, readonly, retain) A* someA;
+@property
@@ -0,0 +1,187 @@
+// RUN: rm -rf %t && mkdir -p %t
+
+// Build and check the unversioned module file.
+// RUN: %clang_cc1 -fmodules -fblocks -fimplicit-module-maps
-fmodules-cache-path=%t/ModulesCache/Unversioned -fdisable-module-hash
-fapinotes-modules -fsyntax-only -I
@@ -0,0 +1,37 @@
+Name: HeaderLib
+SwiftInferImportAsMember: true
+Functions:
+ - Name: custom_realloc
+NullabilityOfRet: N
+Nullability: [ N, S ]
+ - Name: unavailable_function
+Availability: none
+AvailabilityMsg: "I beg you not to use this"
+ - Name:
@@ -0,0 +1 @@
+garbage here because this file shouldn't get read
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1 @@
+extern int PrivateLib;
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,44 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: %clang_cc1 -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t/ModulesCache -fapinotes-modules -Wno-private-module
-fsyntax-only -I %S/Inputs/Headers -F %S/Inputs/Frameworks %s -verify
+
+// Test with Swift
@@ -0,0 +1 @@
+garbage here because this file shouldn't get read
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1 @@
+extern int FrameworkWithActualPrivateModule;
compnerd wrote:
Missing newline
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,187 @@
+// RUN: rm -rf %t && mkdir -p %t
+
+// Build and check the unversioned module file.
+// RUN: %clang_cc1 -fmodules -fblocks -fimplicit-module-maps
-fmodules-cache-path=%t/ModulesCache/Unversioned -fdisable-module-hash
-fapinotes-modules -fsyntax-only -I
@@ -52,49 +52,54 @@ static void applyNullability(Sema , Decl *D,
NullabilityKind Nullability,
if (!Metadata.IsActive)
return;
- auto IsModified = [&](Decl *D, QualType QT,
-NullabilityKind Nullability) -> bool {
+ auto GetModified =
+
@@ -0,0 +1,4 @@
+Name: SomeBrokenLib
+Functions:
+ - Name: do_something_with_pointers
+Nu llabilityOfRet: O
compnerd wrote:
Is it possible to comment that the space here is intentional? Particularly with
this diff, it was difficult to verify until you get
@@ -638,15 +638,15 @@ ObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S,
PDecl->setInvalidDecl();
}
- ProcessDeclAttributes(S, PDecl, FD.D);
-
// Regardless of setter/getter attribute, we save the default getter/setter
// selector names in anticipation of
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Egor Zhdan (egorzhdan)
Changes
This upstreams the last bits of Clang API Notes functionality that is currently
implemented in the Apple fork:
https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes
---
Patch is 113.92 KiB,
egorzhdan wrote:
This depends on https://github.com/llvm/llvm-project/pull/84772.
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
25 matches
Mail list logo
