https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/77465
>From 781201c5c0a526821f51ce6aa0e2c972a9f5f51f Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 9 Jan 2024 14:02:01 +0100
Subject: [PATCH 1/2] [AST] Mark the fallthrough coreturn statement implicit.
---
https://github.com/ChuanqiXu9 approved this pull request.
LGTM then.
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov approved this pull request.
Approve from my side too, but please make sure to apply suggestion from
@cor3ntin and clang-format before submitting.
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing
ilya-biryukov wrote:
> Can you provide more context for this?
I believe this is a follow-up to #77311.
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ChuanqiXu9 wrote:
Can you provide more context for this?
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM modulo nit
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1743,7 +1743,7 @@ bool CoroutineStmtBuilder::makeOnFallthrough() {
return false;
} else if (HasRVoid) {
Fallthrough = S.BuildCoreturnStmt(FD.getLocation(), nullptr,
- /*IsImplicit*/false);
+
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/77465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-coroutines
Author: Haojian Wu (hokein)
Changes
---
Patch is 157.19 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/77465.diff
2 Files Affected:
- (modified) clang/lib/Sema/SemaCoroutine.cpp (+1-1)
-
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/77465
None
>From 17afb4cb0e43ae77268ad406cd2510af69756fae Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 9 Jan 2024 14:02:01 +0100
Subject: [PATCH] [AST] Mark the fallthrough coreturn statement implicit.
---
11 matches
Mail list logo