jhuber6 wrote:
> I disagree, `--gcc-install-dir` is sure an improvement over
> `--gcc-toolchain`, but they're both weaker than the compile time option
> `GCC_INSTALL_PREFIX` because of runtimes.
>
> You're looking to remove `GCC_INSTALL_PREFIX`, then give a clear alternative
> that's
haampie wrote:
I disagree, `--gcc-install-dir` is sure an improvement over `--gcc-toolchain`,
but they're both weaker than the compile time option `GCC_INSTALL_PREFIX`
because of runtimes.
You're looking to remove `GCC_INSTALL_PREFIX`, then give a clear alternative
that's equivalent. The
MaskRay wrote:
> @MaskRay can you please make the error message more informative? It should
> probably say that users additionally have to set `RUNTIMES_CMAKE_ARGS=...` as
> well as generating `clang.cfg`, `clang++.cfg` config files. (And what about
> `flang.cfg` and/or `flang-new.cfg`?)
I
haampie wrote:
Users of `GCC_INSTALL_PREFIX` typically have GCC installed in a unique,
non-standard prefix, where clang's default search just worked.
Now those users have to generate config files for post-install, AND figure out
how to make clang behave correctly when building runtimes.
jhuber6 wrote:
> `-DRUNTIMES_CMAKE_ARGS="-DCMAKE_C_FLAGS=--gcc-install-dir=$GCC_ROOT;-DCMAKE_CXX_FLAGS=--gcc-install-dir=$GCC_ROOT"`
> worked for me
Great, we should probably document this somewhere.
https://github.com/llvm/llvm-project/pull/85891
ye-luo wrote:
`-DRUNTIMES_CMAKE_ARGS="-DCMAKE_C_FLAGS=--gcc-install-dir=$GCC_ROOT;-DCMAKE_CXX_FLAGS=--gcc-install-dir=$GCC_ROOT"`
worked for me
https://github.com/llvm/llvm-project/pull/85891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
petrhosek wrote:
> @petrhosek Is there a way to pass flags only to the runtimes portion of the
> build within the normal workflow? I know we have
> `-DRUNTIMES_x86_64-unknown-linux-gnu_CMAKE_CXX_COMPILE_FLAGS=` that might
> work, but I don't think this is respected if we're using the
jhuber6 wrote:
@petrhosek Is there a way to pass flags only to the runtimes portion of the
build within the normal workflow? I know we have
`-DRUNTIMES_x86_64-unknown-linux-gnu_CMAKE_CXX_COMPILE_FLAGS=` that might work,
but I don't think this is respected if we're using the `default` target.
jhuber6 wrote:
What's the suggested way to handle this in a standard build? The documents
state to use `-DCMAKE_CXX_FLAGS=--gcc-isntall-dir=` but that doesn't work
if you build LLVM with `gcc` initially. You'd need to somehow only pass that
flag to the invocations that use `clang`. We also
ye-luo wrote:
The term deprecated refers to a functionality that still exists in software
whose use is not recommended. Contradictorily, GCC_INSTALL_PREFIX got me fatal
error now without a clear message explaining how to keep it working. I had to
dig deep to figure it out.
Will "temporary"
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/85891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zmodem approved this pull request.
https://github.com/llvm/llvm-project/pull/85891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/85891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
unless USE_DEPRECATED_GCC_INSTALL_PREFIX (temporary escape hatch) is
set. Setting GCC_INSTALL_PREFIX leads to a warning for Clang 18.1
(#77537) and will be completely removed for Clang 20.
Link:
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/85891
unless USE_DEPRECATED_GCC_INSTALL_PREFIX (temporary escape hatch) is
set. Setting GCC_INSTALL_PREFIX leads to a warning for Clang 18.1
(#77537) and will be completely removed for Clang 20.
Link:
15 matches
Mail list logo
