https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> Seems okay to me, but it would be good to include an update to the release
> notes, which ideally shows an example of what replacing the cmake flag with a
> config file would look like.
Thanks for the feedback. I have added pseudocode how GCC installation detection
works in
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/77537
>From 8bd31c3cdb6ce41194b063c9ac13e5e2fbfbcc02 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Thu, 17 Aug 2023 14:01:02 -0700
Subject: [PATCH] [CMake] Deprecate GCC_INSTALL_PREFIX
Part of
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zmodem wrote:
Seems okay to me, but it would be good to include an update to the release
notes, which ideally shows an example of what replacing the cmake flag with a
config file would look like.
https://github.com/llvm/llvm-project/pull/77537
___
https://github.com/tstellar approved this pull request.
I'm in favor of removing this. It doesn't make a lot of sense now that we have
better config file support.
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
Part of https://reviews.llvm.org/D158218
GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from
pre-CMake build system and has configuration file replacement nowadays.
Many `clang/test/Driver`
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/77537
Part of https://reviews.llvm.org/D158218
GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from
pre-CMake build system and has configuration file replacement nowadays.
Many `clang/test/Driver` tests
