[clang] [Clang][NFC] Refactor suspend emit logic in coroutine codegen (PR #73564)

2023-11-28 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/73564 >From 5f5ebec41c90366bf3c7ec1ee53154ba7afcb849 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Wed, 22 Nov 2023 13:38:54 -0800 Subject: [PATCH] Refactor how we generate RValue vs LValue coawait

[clang] [Clang][NFC] Refactor suspend emit logic in coroutine codegen (PR #73564)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Yuxuan Chen (yuxuanchen1997) Changes Depends on https://github.com/llvm/llvm-project/pull/73160 I am not a big fan of the `struct LValueOrRValue`. It appears to me that the intent is to use it like a union, without explicitly

[clang] [Clang][NFC] Refactor suspend emit logic in coroutine codegen (PR #73564)

2023-11-27 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 ready_for_review https://github.com/llvm/llvm-project/pull/73564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Refactor suspend emit logic in coroutine codegen (PR #73564)

2023-11-27 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 created https://github.com/llvm/llvm-project/pull/73564 Depends on https://github.com/llvm/llvm-project/pull/73160 I am not a big fan of the `struct LValueOrRValue`. It appears to me that the intent is to use it like a union, without explicitly saying