https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Thanks for working on that!
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChipsSpectre wrote:
Sorry @tbaederr, I made a mistake in fixing the ReleaseNotes.
Now I added the missing brackets to the link for this issue in the ReleaseNotes.
Could you merge the pull request now?
https://github.com/llvm/llvm-project/pull/74926
_
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From 92ae6f1d822e704cfc8f03d6582772758af3aa66 Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Tue, 2 Jan 2024 17:14:21 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
w
tbaederr wrote:
The documentation build still fails fwiw.
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChipsSpectre wrote:
@tbaederr The build is fixed now. Can you merge the pull request?
Since I have no write access to llvm-project, it seems I can not do it on my
own:
https://github.com/
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From cb46f3aab771133e3987c65bcbd1f6011792e74c Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Sat, 30 Dec 2023 23:01:12 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
tbaederr wrote:
The build fails though, with this error:
``
tools/clang/docs/ReleaseNotes.rst:691:Unknown target name: "#73559
https://github.com/llvm/llvm-project/issues/73559";
``
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mail
tbaederr wrote:
It doesn't need a specific approval, just _any_. And @shafik has already
approved this PR, so it can now be merged.
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
ChipsSpectre wrote:
@tahonermann @AaronBallman @nicolasvasilache @dcaballe Could you please approve
this issue?
The bug is fixed and already approved twice, but the pull request can not be
landed without your approval.
https://github.com/llvm/llvm-project/pull/74926
__
https://github.com/shafik approved this pull request.
If you have addressed all review comments and no one has asked you to wait to
land the PR then you can land once you get an approval.
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits
ChipsSpectre wrote:
@cor3ntin thank you for your fast review!
Is it possible to merge it after your approval, or is it needed to wait for all
reviewers?
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/cor3ntin approved this pull request.
Thanks for working on this! It looks good now
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
ChipsSpectre wrote:
ok @cor3ntin, the nit is addressed.
Is the pull request now ready to be merged?
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From b8bd6e9551da9aefec0597e9ed84cdee2af58344 Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Wed, 20 Dec 2023 17:43:13 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
https://github.com/cor3ntin commented:
Thanks for fixing this bug.
LGTM modulo nit
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2679,6 +2679,8 @@ Parser::ParseCXXClassMemberDeclaration(AccessSpecifier AS,
ParsedAttributes &AccessAttrs,
const ParsedTemplateInfo &TemplateInfo,
ParsingDe
ChipsSpectre wrote:
The Fork is now rebased on main, so the conflict in `ReleaseNotes.rst` is
resolved.
@tbaederr Do you think it is ready to be merged now?
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@list
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From a08d9029445087b78d19715991c426106d9b0ca6 Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Wed, 20 Dec 2023 07:33:20 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From 28a5e6ffab5ec5fef7edce58c4dbdebffcfaabe3 Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Tue, 19 Dec 2023 05:14:06 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
tbaederr wrote:
There's a conflict in the `ReleaseNotes.rst` again unfortunately :(
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChipsSpectre wrote:
@shafik ok, done
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChipsSpectre edited
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
24 matches
Mail list logo
