[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Endilll wrote: > Apparently, buildbot is mad at me > (https://lab.llvm.org/buildbot/#/builders/165/builds/49741)? > > I’m not entirely sure how a fix that affects only > -fdump-record-layouts-complete could have caused this. Is this a spurious > failure or due to something unrelated, or is it

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Sirraide wrote: Apparently, buildbot is mad at me ()? I’m not entirely sure how a fix that affects only `-fdump-record-layouts-complete` could have caused this. Is this a spurious failure or due to something unrelated, or is it worth

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Sirraide wrote: So yeah, this pr indeed also seems to fix #83671 as well. https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/83688 >From 4abc148104769bd756042c73edeb7ee54397a05f Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 2 Mar 2024 20:41:22 +0100 Subject: [PATCH 1/6] [Clang] [Sema] Do not attempt to dump the layout of dependent

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Sirraide wrote: > This might also fix #83671 Actually, it seems to fix your reduced test case, hmm... https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/83688 >From 4abc148104769bd756042c73edeb7ee54397a05f Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 2 Mar 2024 20:41:22 +0100 Subject: [PATCH 1/5] [Clang] [Sema] Do not attempt to dump the layout of dependent

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/83688 >From 4abc148104769bd756042c73edeb7ee54397a05f Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 2 Mar 2024 20:41:22 +0100 Subject: [PATCH 1/4] [Clang] [Sema] Do not attempt to dump the layout of dependent

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

bjrjk wrote: > > This might also fix #83671 > > From what I saw, that’s a different problem, and there’s a different pr for > that already, but I’ll double-check. Seems not same problem, root cause are different. https://github.com/llvm/llvm-project/pull/83688

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Sirraide wrote: Oh, apparently, there’s *yet another* problem here; it seems we should also check for `isInvalidDecl()`. https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Sirraide wrote: > This might also fix #83671 >From what I saw, that’s a different problem, and there’s a different pr for >that already, but I’ll double-check. https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

Endilll wrote: This might also fix #83671 https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/83688 >From 4abc148104769bd756042c73edeb7ee54397a05f Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 2 Mar 2024 20:41:22 +0100 Subject: [PATCH 1/3] [Clang] [Sema] Do not attempt to dump the layout of dependent

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

@@ -5042,7 +5042,7 @@ void RecordDecl::completeDefinition() { // Layouts are dumped when computed, so if we are dumping for all complete // types, we need to force usage to get types that wouldn't be used elsewhere. - if (Ctx.getLangOpts().DumpRecordLayoutsComplete) +

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

@@ -5042,7 +5042,7 @@ void RecordDecl::completeDefinition() { // Layouts are dumped when computed, so if we are dumping for all complete // types, we need to force usage to get types that wouldn't be used elsewhere. - if (Ctx.getLangOpts().DumpRecordLayoutsComplete) +

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/shafik commented: I think this makes sense but I would like another set of eyes. https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes We were crashing on trying to print the layout of an uninstantiated template, which obviously doesn’t make sense. This fixes #83684. --- Full diff: https://github.com/llvm/llvm-project/pull/83688.diff 3 Files

[clang] [Clang] [Sema] Do not attempt to dump the layout of dependent types when `-fdump-record-layouts-complete` is passed (PR #83688)

https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/83688 We were crashing on trying to print the layout of an uninstantiated template, which obviously doesn’t make sense. This fixes #83684. >From 4abc148104769bd756042c73edeb7ee54397a05f Mon Sep 17 00:00:00 2001