[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From 11ceaed39b3f0c60c5a44c3b3a2b5856e7ee9a8d Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/7] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/shafik approved this pull request. I just want to make sure we have enough testing in place for this change but overall I think I am happy. https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,48 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl`, +// we'll try to instantiate and update its explicit

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From b62beb7553f098488e64c81995558c19cd36d785 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/7] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,47 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl`, +// we'll try to instantiate and update its explicit

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/erichkeane commented: Did a better run-through again, so these are all thats left for me. Thanks for the patience! https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,47 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl`, +// we'll try to instantiate and update its explicit

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,47 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl`, +// we'll try to instantiate and update its explicit

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3580,16 +3580,12 @@ static Sema::TemplateDeductionResult instantiateExplicitSpecifierDeferred( if (!Expr->isValueDependent()) { return Sema::TDK_Success; } - // The `InstantiatingTemplate` here is used to restore `ActiveInstType` to - //

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From b62beb7553f098488e64c81995558c19cd36d785 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/6] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From b62beb7553f098488e64c81995558c19cd36d785 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/5] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3580,16 +3580,12 @@ static Sema::TemplateDeductionResult instantiateExplicitSpecifierDeferred( if (!Expr->isValueDependent()) { return Sema::TDK_Success; } - // The `InstantiatingTemplate` here is used to restore `ActiveInstType` to - //

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From b62beb7553f098488e64c81995558c19cd36d785 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/5] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From b62beb7553f098488e64c81995558c19cd36d785 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/4] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/4] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 39b939555f959b93061b3c4c8fffc13a63737074 991212294aefaff304610213baaee927634a6c55 --

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/4] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/4] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3682,6 +3725,17 @@ Sema::TemplateDeductionResult Sema::FinishTemplateArgumentDeduction( } } + // We skipped the instantiation of the explicit-specifier during subst the shafik wrote: This sentence is not super clear, can we spell out `subst` and

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/erichkeane approved this pull request. This is fine to me, please give other reviewers another day to take a look before merging though. https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/3] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH 1/2] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/zyn0217 commented: Thank you for working on this! Some nit comments, hope you don't mind. (Also invited some clang folks to have a detailed look at this. :=) https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From a5929ddc33057416cee75d91f13a1252f4357524 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/70548 From 4f8111b58324d5b670311717d36654f64e6dac01 Mon Sep 17 00:00:00 2001 From: letrec Date: Sat, 28 Oct 2023 18:05:36 +0800 Subject: [PATCH] Defer the instantiation of explicit-specifier after constraint

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/LYP951018 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits