https://github.com/MatzeB closed https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yuxuanchen1997 wrote:
I have made the suggested changes and this is ready for another round of
review.
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/72346
>From 739f1802bbfa4a7dc454e24535423b64701ac500 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 14 Nov 2023 20:52:21 -0800
Subject: [PATCH 1/8] [Clang] Fix ICE caused by mishandling template
bcardosolopes wrote:
I'm not 100% confident here but the fix makes sense and seems good (nice
testcase!).
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erichkeane wrote:
> Thanks for the review, @erichkeane. I am wondering what you mean by this
> needs "release note"?
Ah, yes! See `docs/ReleaseNotes.rst`. For each new bug fix (and most
patches!) we require an entry into our release notes document.
yuxuanchen1997 wrote:
Thanks for the review, @erichkeane. I am wondering what you mean by this needs
"release note"?
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s
yuxuanchen1997 wrote:
gotcha, will do.
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s
erichkeane wrote:
Typically we find a similar test file and put it there, just wrapped in a
namespace for the github issue.
https://github.com/llvm/llvm-project/pull/72346
https://github.com/erichkeane commented:
I don't have a great feel if this is the right fix, but if it doesn't break
anything in the tests, and does fix something, this is likely acceptable for
now.
This DOES need a release note, and as Shafik says: this should likely be placed
in an
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s
yuxuanchen1997 wrote:
Can it be more elaborate like `GH70735-member-template-specialization.cpp`?
https://github.com/llvm/llvm-project/pull/72346
___
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s
shafik wrote:
Normally we put lone tests for a specific bug report in its own file e.g.
GH70735.cpp for this case or we find a test that covers a similar area and put
the test in a namespace named
https://github.com/shafik commented:
This makes some sense but I am not familiar enough with this area.
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yuxuanchen1997 wrote:
@AaronBallman , mind providing some feedback on this patch? I think this can
solve #70375
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/72346
>From f238608b792f69b93eb445ee596125f3e20acf39 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 14 Nov 2023 20:52:21 -0800
Subject: [PATCH 1/5] [Clang] Fix ICE caused by mishandling template
https://github.com/yuxuanchen1997 edited
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yuxuan Chen (yuxuanchen1997)
Changes
This change aims to fix https://github.com/llvm/llvm-project/issues/70375
It appears to me that the logic here should be handling specializations in
general. Not just partial specialization. It also
https://github.com/yuxuanchen1997 ready_for_review
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 created
https://github.com/llvm/llvm-project/pull/72346
This change aims to fix https://github.com/llvm/llvm-project/issues/70375
It appears to me that the logic here should be handling specializations in
general. Not just partial specialization. It also
20 matches
Mail list logo
