Bigcheese wrote:
This incorrectly handles `-gmodules` which produces an object file that
contains a clang PCH. Detecting that is a bit harder, is it fine if it just
accepts all object files as returned by `llvm::identify_magic`?
https://github.com/llvm/llvm-project/pull/69204
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/69204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/69204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zmodem wrote:
@MaskRay ping?
https://github.com/llvm/llvm-project/pull/69204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann approved this pull request.
This looks great to me. Thank you for working on this!
Please give @MaskRay a chance to comment on this before merging it.
https://github.com/llvm/llvm-project/pull/69204
___
cfe-commits
zmodem wrote:
Please take a look.
This has the benefit of fixing users broken by gcc-generated .gch files without
having to wait a release cycle for deprecation, while at the same time not
breaking users relying clang performing these probes at all.
cc folks from the previous pr:
@MaskRay
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Hans (zmodem)
Changes
Instead of deprecating the "gch probe" as in
f726da1193baf51e0a66453cc32dcffb8a9121d4, this makes clang ignore files which
are not clang pch files (See discussion on PR #67084).
This fixes the issues mentioned in
https://github.com/zmodem created
https://github.com/llvm/llvm-project/pull/69204
Instead of deprecating the "gch probe" as in
f726da1193baf51e0a66453cc32dcffb8a9121d4, this makes clang ignore files which
are not clang pch files (See discussion on PR #67084).
This fixes the issues mentioned
