https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/80527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mstorsjo approved this pull request.
If nobody else wants to chime in here, I guess I'll go ahead and approve it.
LGTM!
https://github.com/llvm/llvm-project/pull/80527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaskRay wrote:
Ping:)
https://github.com/llvm/llvm-project/pull/80527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> From my point of view, I think this sounds fine - it looks like you've looked
> through this and thought deeper about it than I have at least. I'm not deep
> enough into this to comfortably press approved on this for now though, so
> hopefully someone else can chime in as
mstorsjo wrote:
From my point of view, I think this sounds fine - it looks like you've looked
through this and thought deeper about it than I have at least. I'm not deep
enough into this to comfortably press approved on this for now though, so
hopefully someone else can chime in as well.
MaskRay wrote:
Ping:)
@ldionne I know you are discussing a `-isysroot` related issue (don't recall
which one off my head) for Apple platforms. I think unifying InstalledDir and
Dir will help.
https://github.com/llvm/llvm-project/pull/80527
___
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/80527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
`Driver::ClangExecutable` is derived from:
* (-canonical-prefixes default): `realpath` on the executable path
* (-no-canonical-prefixes) argv[0] (consult PATH if argv[0] is a word)
`Dir` and `ResourceDir`
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/80527
`Driver::ClangExecutable` is derived from:
* (-canonical-prefixes default): `realpath` on the executable path
* (-no-canonical-prefixes) argv[0] (consult PATH if argv[0] is a word)
`Dir` and `ResourceDir` are
