https://github.com/python3kgae closed
https://github.com/llvm/llvm-project/pull/83340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/83340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/83340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/83340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bogner wrote:
If we want to talk about guidelines for clang-formatting tests in general we
should probably bring it up with the wider LLVM community on discourse. The de
facto standard today is that tests should be well formatted like anything else
unless there's a good reason not to, but
farzonl wrote:
> Do we have the suggestions that this is responding to written down somewhere?
> I think it would be useful to have those guidelines for anyone who might want
> to contribute HLSL tests. At any rate, I'd like to know the ones that this is
> in response to.
After consulting
farzonl wrote:
> > Do we have the suggestions that this is responding to written down
> > somewhere? I think it would be useful to have those guidelines for anyone
> > who might want to contribute HLSL tests. At any rate, I'd like to know the
> > ones that this is in response to.
>
>
farzonl wrote:
> Do we have the suggestions that this is responding to written down somewhere?
> I think it would be useful to have those guidelines for anyone who might want
> to contribute HLSL tests. At any rate, I'd like to know the ones that this is
> in response to.
@pow2clk
below are
damyanp wrote:
> Do we have the suggestions that this is responding to written down somewhere?
> I think it would be useful to have those guidelines for anyone who might want
> to contribute HLSL tests. At any rate, I'd like to know the ones that this is
> in response to.
Following on from
pow2clk wrote:
Do we have the suggestions that this is responding to written down somewhere? I
think it would be useful to have those guidelines for anyone who might want to
contribute HLSL tests. At any rate, I'd like to know the ones that this is in
response to.
llvmbot wrote:
@llvm/pr-subscribers-hlsl
@llvm/pr-subscribers-clang
Author: Farzon Lotfi (farzonl)
Changes
This PR brings best practices mentioned to me on other prs and adds them to the
existing builtin tests.
Note to reviewers: I put this up in two commits because the clang-format
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/83340
This PR brings best practices mentioned to me on other prs and adds them to the
existing builtin tests.
Note to reviewers: I put this up in two commits because the clang-format
changes is making it hard to
12 matches
Mail list logo
