https://github.com/aniplcc updated
https://github.com/llvm/llvm-project/pull/86571
>From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001
From: aniplcc
Date: Tue, 26 Mar 2024 01:35:36 +0530
Subject: [PATCH 1/4] [HLSL] Enable -fconvergent-functions by default
---
aniplcc wrote:
Ah it's the spir-v check, apologies, forgot to check that
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aniplcc wrote:
check fails with
```
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-6mhbj-1/llvm-project/github-pull-requests/clang/test/CodeGenHLSL/convergent-functions.hlsl:7:11:
error: CHECK: expected string not found in input
// CHECK: define void {{.*}}fn{{.*}}()
^
:1:1: note:
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aniplcc wrote:
Updated
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aniplcc updated
https://github.com/llvm/llvm-project/pull/86571
>From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001
From: aniplcc
Date: Tue, 26 Mar 2024 01:35:36 +0530
Subject: [PATCH 1/3] [HLSL] Enable -fconvergent-functions by default
---
llvm-beanz wrote:
> I was getting match errors with the RUN script. I went ahead and updated it
> with the checks in: `clang/test/CodeGen/convergent-functions.cpp` Hope that's
> correct/OK?
>
> ```hlsl
> // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.4-library -emit-llvm
>
https://github.com/aniplcc updated
https://github.com/llvm/llvm-project/pull/86571
>From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001
From: aniplcc
Date: Tue, 26 Mar 2024 01:35:36 +0530
Subject: [PATCH 1/2] [HLSL] Enable -fconvergent-functions by default
---
aniplcc wrote:
I was getting match errors with the RUN script. I went ahead and updated it
with the checks in:
`clang/test/CodeGen/convergent-functions.cpp`
Hope that's correct/OK?
```hlsl
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.4-library -emit-llvm
-disable-llvm-passes -o - %s
llvm-beanz wrote:
Hi @aniplcc, thank you for the PR.
We do require test cases for bug fixes and new features (see the [Developer
Policy](https://llvm.org/docs/DeveloperPolicy.html#test-cases).
Because this general feature is already tested for OpenCL, we can make a really
simple test for
aniplcc wrote:
Requesting review, @llvm-beanz
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: aniplcc (aniplcc)
Changes
Fixes #86506
---
Full diff: https://github.com/llvm/llvm-project/pull/86571.diff
1 Files Affected:
- (modified) clang/lib/Frontend/CompilerInvocation.cpp (+3-2)
``diff
diff --git
https://github.com/aniplcc created
https://github.com/llvm/llvm-project/pull/86571
Fixes #86506
>From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001
From: aniplcc
Date: Tue, 26 Mar 2024 01:35:36 +0530
Subject: [PATCH] [HLSL] Enable -fconvergent-functions by default
---
15 matches
Mail list logo
