https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
@shafik from the last message, it seemed like this is good to go, but you
didn't approve, so I am wondering if you forgot.
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
shafik wrote:
Thank you for improving the description. The description is usually what ends
up in the git log and so it is important for that summary there to be as
helpful and descriptive as possible.
https://github.com/llvm/llvm-project/pull/67751
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
Thanks for the review.
I think the change stands on itself, as we are avoiding storing one pointer per
Type Node instance, for the cost of one extra pointer per ASTContext, which is
negligible.
These type nodes we are changing here are old, at least as far back as 2008.
In
shafik wrote:
Thank you for the PR. Could you provide some context in the PR description?
From the title it sounds like there were prior changes that this is finishing.
It would be helpful to have a link to those prior changes.
https://github.com/llvm/llvm-project/pull/67751
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/67751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/67751
>From 5919cbf2a91f1cff3e48ba10cd2e9f5d2f5023f0 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Fri, 29 Sep 2023 00:49:16 +0200
Subject: [PATCH] [NFC][clang] change remaining context-dependent type nodes to
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Stacked, consider only last commit.
---
Patch is 28.71 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/67751.diff
6 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+3)
- (modified)
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/67751
Stacked, consider only last commit.
>From 7009ebf7f2016816b5cbb694e0611cd2a86d7cf1 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 28 Sep 2023 22:38:59 +0200
Subject: [PATCH 1/2] [clang] implement
12 matches
Mail list logo
