[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Updated in 68281947f7df4c7325b862857fbf3ed06d711f74. https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Sorry. I'll wait longer to merge next time. I'll push a fixup to address the > comment. Thanks for the comment/review! No need to be sorry, it's my fault. Thanks for improving documentation. https://github.com/llvm/llvm-project/pull/68636

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Sorry. I'll wait longer to merge next time. I'll push a fixup to address the comment. Thanks for the comment/review! https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I am to late with comment, can you make it in the same style as https://llvm.org/docs/CMake.html One line, and with $: ``` .. code-block:: console $ cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_RUNTIMES="compiler-rt" path/to/llvm/source

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Currently the documentation for building Asan doesn't specify that compiler-rt needs to be built as well. In addition, there's no minimal example for the LLVM CMake configuration. This patch addresses both of these issues. The lack of

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/68636 Currently the documentation for building Asan doesn't specify that compiler-rt needs to be built as well. In addition, there's no minimal example for the LLVM CMake configuration. This patch addresses