AaronBallman wrote:
> @AaronBallman Can you describe your current plan how driver options are going
> to behave in the light of `#embed`?
I'm flexible with how we proceed, so if others have different ideas, feel free
to suggest them! But my initial inclination is:
* `--embed-dir=` as a way
Endilll wrote:
@AaronBallman Can you describe your current plan how driver options are going
to behave in the light of `#embed`?
https://github.com/llvm/llvm-project/pull/68620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
> @AaronBallman, hope the WG14 meeting went well? I've essentially done what I
> planned to do here, so I was wondering if you're ready to take it from here?
> I can try to incorporate the review feedback myself, but it's quite likely
> I'd make a mess of it (not familiar
h-vetinari wrote:
@AaronBallman, hope the WG14 meeting went well? I've essentially done what I
planned to do here, so I was wondering if you're ready to take it from here? I
can try to incorporate the review feedback myself, but it's quite likely I'd
make a mess of it (not familiar with the
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/68620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/68620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -816,6 +821,14 @@ will be ignored}]>;
def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group,
Visibility<[ClangOption, FlangOption]>,
MetaVarName<"">, HelpText<"Add directory to library search path">;
+def embed_dir : JoinedOrSeparate<["-"],
h-vetinari wrote:
JeanHeyd wrote up a [blog
post](https://thephd.dev/implementing-embed-c-and-c++) about this
implementation, which is probably helpful as background material for any
prospective reviewers. :)
https://github.com/llvm/llvm-project/pull/68620
https://github.com/ThePhD edited https://github.com/llvm/llvm-project/pull/68620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
h-vetinari wrote:
OK, I've got a first rebase going. However, because iterating on a diff with
1000s of lines is extremely hard to review and bound to lead to mistakes and
iterations (making it harder still to follow what's going on), I've tried to
follow a more structured approach.
h-vetinari wrote:
> @h-vetinari -- would you mind doing some initial cleanup on the patch for
> things like rebasing, removing spurious formatting changes, naming, and the
> likes?
I'll try to do that!
https://github.com/llvm/llvm-project/pull/68620
AaronBallman wrote:
> > > Because I don't know of any better way to commandeer a patch in GitHub
> >
> >
> > As a maintainer, you can push into this branch
>
> I had reached out to @ThePhD with an offer to help on this before they opened
> this PR, and I now have push access to their fork,
h-vetinari wrote:
> > Because I don't know of any better way to commandeer a patch in GitHub
>
> As a maintainer, you can push into this branch
I had reached out to @ThePhD with an offer to help on this before they opened
this PR, and I now have push access to their fork, which means I could
shafik wrote:
> FWIW, I spoke offline with the original author of the PR and he said that
> he's fine with me picking up the changes and carrying the review forward.
>
> Because I don't know of any better way to commandeer a patch in GitHub, I'll
> probably grab the changes, get them into my
jyknight wrote:
> This pull request implements the entirety of the now-accepted N3017 -
> Preprocessor Embed.
Amazing! I had started to think about looking into getting this implemented
recently, so it's really nice to see an implementation uploaded now!
> I have no intention of following up
h-vetinari wrote:
> Because I don't know of any better way to commandeer a patch in GitHub
As a maintainer, you can push into this branch (unless @ThePhD unchecked the
default setting when creating the PR), including forcefully.
For example (you could also use the github CLI, but I'm using
AaronBallman wrote:
FWIW, I spoke offline with the original author of the PR and he said that he's
fine with me picking up the changes and carrying the review forward.
Because I don't know of any better way to commandeer a patch in GitHub, I'll
probably grab the changes, get them into my own
@@ -1464,6 +1467,21 @@ class AnnotatingParser {
}
}
+ void parseEmbedDirective() {
+if (CurrentToken && CurrentToken->is(tok::less)) {
+ next();
+ while (CurrentToken) {
+// Mark tokens up to the trailing line comments as implicit string
+
@@ -1464,6 +1467,21 @@ class AnnotatingParser {
}
}
+ void parseEmbedDirective() {
+if (CurrentToken && CurrentToken->is(tok::less)) {
+ next();
+ while (CurrentToken) {
+// Mark tokens up to the trailing line comments as implicit string
+
@@ -1500,6 +1518,14 @@ class AnnotatingParser {
next(); // ')'
}
+ void parseHasEmbed() {
+if (!CurrentToken || CurrentToken->isNot(tok::l_paren))
+ return;
+next(); // '('
+parseEmbedDirective();
+next(); // ')'
HazardyKnusperkeks
@@ -1464,6 +1467,21 @@ class AnnotatingParser {
}
}
+ void parseEmbedDirective() {
+if (CurrentToken && CurrentToken->is(tok::less)) {
+ next();
+ while (CurrentToken) {
+// Mark tokens up to the trailing line comments as implicit string
+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 67b675ee55cce183b93874a38ab94eee00aedbcc
adc973776a526f97b6da2435edf143a10e7e0ad5 --
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Changes
This pull request implements the entirety of the now-accepted [N3017 -
Preprocessor Embed](https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3017.htm)
and its sister C++ paper [p1967](https://wg21.link/p1967). It implements
https://github.com/ThePhD edited https://github.com/llvm/llvm-project/pull/68620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
24 matches
Mail list logo
