https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/79588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
This passed precommit CI before and the only difference is that there are
formatting changes removed, so I'm landing this before precommit CI finishes.
https://github.com/llvm/llvm-project/pull/79588
___
cfe-commits mailing list
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the fix!
https://github.com/llvm/llvm-project/pull/79588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pileghoff wrote:
> It looks like a bunch of formatting changes came in with SemaChecking.cpp.
> You should only be formatting the code that your patch needs to touch. We've
> got a script for that:
> https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting or
>
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From ee164634ffd2db4a7e590faeba7a3a631e8e75db Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/AaronBallman requested changes to this pull request.
It looks like a bunch of formatting changes came in with SemaChecking.cpp. You
should only be formatting the code that your patch needs to touch. We've got a
script for that:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e37a6008831b38477516362892dd3c0d97087eff
aea883b73a072e8a7bd261a4d6b5885660bd215f --
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 38d96aba5818091d48c40a46738f5adbf881b2a8 Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From f22d0a6888be86c5105a00e3f83201f71165f78f Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From b059e03eb5330054e76c833699611fdc9bfb1967 Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 6ea74d7aa0eadd4093350c04de95cbb2bdbaf0eb Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 29a1eea6b27210ba35ad035b3c10aa8f5c73d86c Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 34bb01d59005059c7f8f1156a164993c1839ee36 Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 2c942f755c147a8413af4784f85da46f1f5384bd Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
pileghoff wrote:
For testing i have fixed the new warnings in `n3042.c` and i have expanded
`warn-int-in-bool-context.c` to check c23 specefically (which was broken, but
is now fixed) and i added a few extra cases to the test. I will take a look at
the release notes later today.
https://github.com/pileghoff updated
https://github.com/llvm/llvm-project/pull/79588
>From 43241ab75d4c15e6885337be1b0ce4cf0217f384 Mon Sep 17 00:00:00 2001
From: Pil Eghoff
Date: Fri, 26 Jan 2024 13:30:17 +0100
Subject: [PATCH] [Sema] Fix c23 not checking CheckBoolLikeConversion
---
pileghoff wrote:
I can also see i broke the `n3042.c` test. Stuff like `if (null_val) {}` now
throws a warning, since `null_val` is a constant.
I would expect this warning to be okay in that scenario?
https://github.com/llvm/llvm-project/pull/79588
pileghoff wrote:
> Thank you for the Fix! Your summary should be a description of the problem
> and how your solution fixes that problem. You should also link to the github
> issue in the summary.
>
> Questions about the changes in the PR should go as a comment to the PR.
>
> Please add a
https://github.com/pileghoff edited
https://github.com/llvm/llvm-project/pull/79588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Thank you for the Fix! Your summary should be a description of the problem and
how your solution fixes that problem. You should also link to the github issue
in the summary.
Questions about the changes in the PR should go as a comment to the PR.
Please
pileghoff wrote:
@AaronBallman If you have time for review, the PR is ready
https://github.com/llvm/llvm-project/pull/79588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pil Eghoff (pileghoff)
Changes
Fixes #79435
Im not sure if this is the best solution, but it seems to work well.
Should i be adding tests for this? If i should, i would need some help on how.
I was able to run the test suite, but i have
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/pileghoff created
https://github.com/llvm/llvm-project/pull/79588
Fixes #79435
Im not sure if this is the best solution, but it seems to work well.
Should i be adding tests for this? If i should, i would need some help on how.
I was able to run the test suite, but i have
24 matches
Mail list logo
