[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/66853 >From 701b1d99515e40eec8dcbaba3a0b2dc436bf9652 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Tue, 19 Sep 2023 19:46:56 -0700 Subject: [PATCH] [Sema] Fix fixit cast printing inside macros

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-20 Thread Alex Brachet via cfe-commits
https://github.com/abrachet approved this pull request. Awesome! I couldn't figure this out when I looked :) https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
smeenai wrote: I updated the PR description with an example. https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai edited https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Since this is a diagnostic improvement, can you post the before and after output of an example? https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the end location directly

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

2023-09-19 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/66853 `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the