https://github.com/bd1976bris updated
https://github.com/llvm/llvm-project/pull/75364
>From 97efed8c73aed4fdca5510013c844e84953ec256 Mon Sep 17 00:00:00 2001
From: Ben Dunbobbin
Date: Tue, 12 Dec 2023 08:07:17 +
Subject: [PATCH 1/4] [Sema] Provide `-fno-/-fvisibility-global-new-delete`
zygoloid wrote:
To be clear: I didn't mean to suggest that
`-fvisibility-global-new-delete=force-hidden` itself would be deprecated. I
think supporting it would have low cost and it may be exactly what is desired
in some cases, and the previous spelling [has quite a few
bd1976bris wrote:
@zygoloid - yes, the choice of "default" for the name of one of the visibility
values in ELF is annoying :) Thanks for the comments all. I feel that what we
might need is a bit of a benevolent dictator here. Does anyone object to
Richard's `-fvisibility-global-new-delete=`
zygoloid wrote:
How about instead using `-fvisibility-global-new-delete=`? We want a
mutually-exclusive set of options here, and we know we want more than two of
them, and a flag with an argument value is the way we usually express that.
Perhaps we can use values of `force-hidden`,
frobtech wrote:
> Actually I kind of prefer all these options to have `-fvisibility-` as a
> prefix. Even if it doesn't read quite naturally, it strongly implies that the
> options are related (which is true) and any lexically sorted list of options
> will naturally group them together. WDYT
pogo59 wrote:
Actually I kind of prefer all these options to have `-fvisibility-` as a
prefix. Even if it doesn't read quite naturally, it strongly implies that the
options are related (which is true) and any lexically sorted list of options
will naturally group them together. WDYT @frobtech
bd1976bris wrote:
I have updated the patch to use `-f[no-]forced-global-new-delete-visibility` as
suggested.
https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/bd1976bris updated
https://github.com/llvm/llvm-project/pull/75364
>From 97efed8c73aed4fdca5510013c844e84953ec256 Mon Sep 17 00:00:00 2001
From: Ben Dunbobbin
Date: Tue, 12 Dec 2023 08:07:17 +
Subject: [PATCH 1/3] [Sema] Provide `-fno-/-fvisibility-global-new-delete`
bd1976bris wrote:
Thanks for the responses.
> The meaning that we want to make clear is that this toggles the special
> behavior of forcing the visibility of these symbols despite all the other
> mechanisms that usually control visibility for all other symbols.
Agreed. I'm in favour of your
frobtech wrote:
The meaning that we want to make clear is that this toggles the special
behavior of forcing the visibility of these symbols despite all the other
mechanisms that usually control visibility for all other symbols. So perhaps
`-fforced-global-new-delete-visibility` (or even
petrhosek wrote:
I don't think it's very clear from `-f[no-]visibility-global-new-delete` what
the option does. How about `-f[no-]visibility-attribute-global-new-delete`?
https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
bd1976bris wrote:
> From a UI perspective, "add a visibility attribute" doesn't seem all that
> descriptive. What visibility does it add? Therefore, I suggest
> `-fvisibility-global-new-delete[=]` so the user can ask for what
> they want, and `-fvisibility-global-new-delete-hidden` equals
>
pogo59 wrote:
>From a UI perspective, "add a visibility attribute" doesn't seem all that
>descriptive. What visibility does it add? Therefore, I suggest
>`-fvisibility-global-new-delete[=]` so the user can ask for what
>they want, and `-fvisibility-global-new-delete-hidden` equals
bd1976bris wrote:
Noting previous discussions w.r.t. -fvisibility-global-new-delete-hidden on
https://reviews.llvm.org/D133266. I have added reviewers from that phab review
in case they are interested in this.
https://github.com/llvm/llvm-project/pull/75364
https://github.com/bd1976bris updated
https://github.com/llvm/llvm-project/pull/75364
>From 97efed8c73aed4fdca5510013c844e84953ec256 Mon Sep 17 00:00:00 2001
From: Ben Dunbobbin
Date: Tue, 12 Dec 2023 08:07:17 +
Subject: [PATCH 1/2] [Sema] Provide `-fno-/-fvisibility-global-new-delete`
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 83dabd0569965cf9923ad552d030b9e87ee694c9
97efed8c73aed4fdca5510013c844e84953ec256 --
bd1976bris wrote:
See #74629 for more on visibility support in PlayStation.
https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: bd1976bris (bd1976bris)
Changes
By default the implicitly declared replaceable global new and delete operators
are given a `default` visibility attribute. Previous work, see:
https://github.com/bd1976bris created
https://github.com/llvm/llvm-project/pull/75364
By default the implicitly declared replaceable global new and delete operators
are given a `default` visibility attribute. Previous work, see:
https://reviews.llvm.org/D53787, added
19 matches
Mail list logo
