https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spaits wrote:
> It's unrelated to your changes. Configuration issue on the CI, probably
Okay. Then I will merge this.
Thank you very much for reviewing my PR and helping me.
https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing
=?utf-8?q?G=C3=A1bor?= Spaits,Gabor Spaits ,Gabor
Spaits
Message-ID:
In-Reply-To:
cor3ntin wrote:
It's unrelated to your changes. Configuration issue on the CI, probably
https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
spaits wrote:
@cor3ntin I see that you have CI runs that fail with exactly the same reason as
my runs:
https://buildkite.com/llvm-project/clang-ci/builds/10874#018d49c2-1224-4939-9430-0e5a2be796a9
.
https://github.com/llvm/llvm-project/pull/79371
spaits wrote:
Thank you for reviewing.
Before merge we should take a look at the CI.
It still fails for libc++ 26 suite, with the same reason as before.
I wanted to reproduce the issue. I built libc++ with the clang++ I compiled:
```
cmake -S "../runtimes" -GNinja \
=?utf-8?q?G=C3=A1bor?= Spaits,Gabor Spaits ,Gabor
Spaits
Message-ID:
In-Reply-To:
https://github.com/cor3ntin approved this pull request.
Thanks for working on this!
The changes looks good to me.
Will you need me to merge them on your behalf?
https://github.com/llvm/llvm-project/pull/79371
@@ -858,6 +859,27 @@ class PackDeductionScope {
Info.PendingDeducedPacks[Pack.Index] = Pack.Outer;
}
+ // Return the size of the saved packs if all of them has the same size.
+ std::optional getSavedPackSizeIfAllEqual() const {
+if (Packs.size() == 0 ||
+
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/16] [Sema]Substitue template parameter packs when deduced
from
=?utf-8?q?Gábor?= Spaits,Gabor Spaits
Message-ID:
In-Reply-To:
@@ -858,6 +859,27 @@ class PackDeductionScope {
Info.PendingDeducedPacks[Pack.Index] = Pack.Outer;
}
+ // Return the size of the saved packs if all of them has the same size.
+ std::optional
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -858,6 +859,27 @@ class PackDeductionScope {
Info.PendingDeducedPacks[Pack.Index] = Pack.Outer;
}
+ // Return the size of the saved packs if all of them has the same size.
+ std::optional getSavedPackSizeIfAllEqual() const {
+if (Packs.size() == 0 ||
+
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack {
i(0, 1, 2, 3, 4, 5); // expected-error {{no match}}
}
+ template
+ void bar(args_tag, type_identity_t..., int mid,
type_identity_t...) {}
spaits wrote:
Added the test. It also works.
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/15] [Sema]Substitue template parameter packs when deduced
from
=?utf-8?q?G=C3=A1bor?= Spaits
Message-ID:
In-Reply-To:
@@ -858,6 +859,27 @@ class PackDeductionScope {
Info.PendingDeducedPacks[Pack.Index] = Pack.Outer;
}
+ // Return the size of the saved packs if all of them has the same size.
+ std::optional
=?utf-8?q?G=C3=A1bor?= Spaits
Message-ID:
In-Reply-To:
@@ -858,6 +859,27 @@ class PackDeductionScope {
Info.PendingDeducedPacks[Pack.Index] = Pack.Outer;
}
+ // Return the size of the saved packs if all of them has the same size.
+ std::optional
=?utf-8?q?Gábor?= Spaits
Message-ID:
In-Reply-To:
erichkeane wrote:
> I did some more digging. I saw that the test in the CI fails with permission
> errors.
>
> ```
> | No symbol table is loaded. Use the "file" command.
> | warning: opening /proc/PID/mem file for lwp 4103309.4103309 failed:
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/14] [Sema]Substitue template parameter packs when deduced
from
@@ -4371,6 +4394,34 @@ Sema::TemplateDeductionResult
Sema::DeduceTemplateArguments(
// corresponding argument is a list?
PackScope.nextPackElement();
}
+ } else if (!IsTrailingPack && !PackScope.isPartiallyExpanded() &&
+
spaits wrote:
I did some more digging. I saw that the test in the CI fails with permission
errors.
```
| No symbol table is loaded. Use the "file" command.
| warning: opening /proc/PID/mem file for lwp 4103309.4103309 failed:
Permission denied (13)
| Traceback (most recent call last):
|
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack {
i(0, 1, 2, 3, 4, 5); // expected-error {{no match}}
}
+ template
+ void bar(args_tag, type_identity_t..., int mid,
type_identity_t...) {}
cor3ntin wrote:
I'd like to see a test for
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From 3e0c3db0d8500e5f2111e3603da3d8f2b1cd261d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced
from
spaits wrote:
It looks like libc++ test suites are failing. Looking at the logs from the CI I
can not really figure out what is the exact reason.
I could only deduce that the failing test case is
`libcxx/gdb/gdb_pretty_printer_test.sh.cpp`. This case seems to be related to
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From 38107a96c18fc5d008873fbac5257f0f476799f3 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced
from
@@ -431,6 +442,17 @@ namespace deduction_after_explicit_pack {
i(0, 1, 2, 3, 4, 5); // expected-error {{no match}}
}
+ template
+ void bar(args_tag, type_identity_t..., int mid,
type_identity_t...) {}
spaits wrote:
I added a test for this.
spaits wrote:
> > @cor3ntin @erichkeane Thank you for checking the updates on my PR. I fixed
> > the typo and added the release notes. Also rebased the branch.
>
> Looks like the release notes change failed CI.
Not my changes. This was commited 3 hours ago:
erichkeane wrote:
> @cor3ntin @erichkeane Thank you for checking the updates on my PR. I fixed
> the typo and added the release notes. Also rebased the branch.
Looks like the release notes change failed CI.
https://github.com/llvm/llvm-project/pull/79371
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From a27fe8c4179a58a741121eec9e8368c9ab44d7cc Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/13] [Sema]Substitue template parameter packs when deduced
from
spaits wrote:
@cor3ntin @erichkeane
Thank you for checking the updates on my PR.
I fixed the typo and added the release notes.
https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/79371
From a27fe8c4179a58a741121eec9e8368c9ab44d7cc Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Wed, 24 Jan 2024 21:21:26 +0100
Subject: [PATCH 01/12] [Sema]Substitue template parameter packs when deduced
from
https://github.com/spaits edited https://github.com/llvm/llvm-project/pull/79371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
31 matches
Mail list logo
