efriedma-quic wrote:
LGTM
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HerrCai0907 wrote:
> I guess this ends up producing a CK_NoOp CastExpr? That's probably okay, but
> can we amend the documentation for CK_NoOp to give this as an example?
Done
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65918
>From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Sep 2023 09:15:41 +0800
Subject: [PATCH 1/6] [Sema] add cast from IncompleteArrayType to
efriedma-quic wrote:
I guess this ends up producing a CK_NoOp CastExpr? That's probably okay, but
can we amend the documentation for CK_NoOp to give this as an example?
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65918
>From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Sep 2023 09:15:41 +0800
Subject: [PATCH 1/5] [Sema] add cast from IncompleteArrayType to
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema ,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema ,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65918
>From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Sep 2023 09:15:41 +0800
Subject: [PATCH 1/5] [Sema] add cast from IncompleteArrayType to
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65918:
>From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Sep 2023 09:15:41 +0800
Subject: [PATCH 1/4] [Sema] add cast from IncompleteArrayType to
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema ,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/65918:
>From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 11 Sep 2023 09:15:41 +0800
Subject: [PATCH 1/3] [Sema] add cast from IncompleteArrayType to
https://github.com/Fznamznon commented:
This needs a release note.
cc @erichkeane
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema ,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if
@@ -4532,6 +4532,15 @@ static void TryReferenceListInitialization(Sema ,
if (T1Quals.hasAddressSpace())
Sequence.AddQualificationConversionStep(
cv1T1, DestType->isRValueReferenceType() ? VK_XValue : VK_LValue);
+ else if
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@Fznamznon
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin unassigned
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Fixed: https://github.com/llvm/llvm-project/issues/62945
c++20 supports "Permit conversions to arrays of unknown bound". This need
additional cast from IncompleteArrayType to ConstantArrayType in
TryReferenceListInitialization
--
Full diff:
HerrCai0907 wrote:
from https://reviews.llvm.org/D151515
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/65918:
Fixed: https://github.com/llvm/llvm-project/issues/62945
c++20 supports "Permit conversions to arrays of unknown bound". This need
additional cast from IncompleteArrayType to ConstantArrayType in
https://github.com/HerrCai0907 review_requested
https://github.com/llvm/llvm-project/pull/65918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
24 matches
Mail list logo
