mikhailramalho wrote:
I opened this PR before we spoke offline, I'm closing it now
https://github.com/llvm/llvm-project/pull/91068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mikhailramalho closed
https://github.com/llvm/llvm-project/pull/91068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
I'm not certain that we want to ignore all instances of VM& like this. It's
certainly possible for some use of VM& to be unsafe. It might be better to
suppress the warning explicitly instead.
https://github.com/llvm/llvm-project/pull/91068
https://github.com/mikhailramalho updated
https://github.com/llvm/llvm-project/pull/91068
>From a770060da101720ffddc033fd37db790eaa17710 Mon Sep 17 00:00:00 2001
From: "Mikhail R. Gadelha"
Date: Sat, 4 May 2024 13:08:32 -0300
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Ignore
https://github.com/mikhailramalho updated
https://github.com/llvm/llvm-project/pull/91068
>From dde31272c1599a699c49117c1612ae72d0491384 Mon Sep 17 00:00:00 2001
From: "Mikhail R. Gadelha"
Date: Sat, 4 May 2024 13:08:32 -0300
Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Ignore
mikhailramalho wrote:
Hey @rniwa, if you want I can send the `safeGetName` changes in a separate
patch.
I was planning to unify this with `isMethodOnWTFContainerType` so there is
some duplicated code here.
I'll update the PR next week with some tests.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 76aa042dde6ba9ba57c680950f5818259ee02690
7f59654193385e78e1635c9bb2a627522f888b8d --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mikhail R. Gadelha (mikhailramalho)
Changes
This patch also updates safeGetName to get names from operators without hitting
an assertion
---
Full diff: https://github.com/llvm/llvm-project/pull/91068.diff
2 Files Affected:
-
https://github.com/mikhailramalho created
https://github.com/llvm/llvm-project/pull/91068
This patch also updates safeGetName to get names from operators without hitting
an assertion
>From 7f59654193385e78e1635c9bb2a627522f888b8d Mon Sep 17 00:00:00 2001
From: "Mikhail R. Gadelha"
Date: Sat,
