@@ -30,3 +30,24 @@ void test(int i) {
clang_analyzer_dump(g4);
// expected-warning@-1 {{ [as 64 bit integer]}}
}
+
+struct A {
+ int n;
+ void set(int x) {
+n = x;
+ }
+};
+using ptr_size = decltype(sizeof(void *));
DonatNagyE wrote:
Thanks!
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/70837
>From 2de19fc8e14319674ce87c18771ba1b8ba22f79b Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 23 Oct 2023 18:10:29 +0200
Subject: [PATCH 1/3] [analyzer] Fix assertion failure in
@@ -30,3 +30,24 @@ void test(int i) {
clang_analyzer_dump(g4);
// expected-warning@-1 {{ [as 64 bit integer]}}
}
+
+struct A {
+ int n;
+ void set(int x) {
+n = x;
+ }
+};
+using ptr_size = decltype(sizeof(void *));
steakhal wrote:
Fixed. Now using
@@ -30,3 +30,24 @@ void test(int i) {
clang_analyzer_dump(g4);
// expected-warning@-1 {{ [as 64 bit integer]}}
}
+
+struct A {
+ int n;
+ void set(int x) {
+n = x;
+ }
+};
+using ptr_size = decltype(sizeof(void *));
+void gh_69922(ptr_size p) {
+ //
https://github.com/DonatNagyE commented:
Basically LGTM, thanks for fixing this crash.
I don't give a formal approval because I didn't independently verify the
correctness of the details, but I like the direction of the change.
https://github.com/llvm/llvm-project/pull/70837
@@ -30,3 +30,24 @@ void test(int i) {
clang_analyzer_dump(g4);
// expected-warning@-1 {{ [as 64 bit integer]}}
}
+
+struct A {
+ int n;
+ void set(int x) {
+n = x;
+ }
+};
+using ptr_size = decltype(sizeof(void *));
+void gh_69922(ptr_size p) {
+ //
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,3 +30,24 @@ void test(int i) {
clang_analyzer_dump(g4);
// expected-warning@-1 {{ [as 64 bit integer]}}
}
+
+struct A {
+ int n;
+ void set(int x) {
+n = x;
+ }
+};
+using ptr_size = decltype(sizeof(void *));
DonatNagyE wrote:
Do I see it
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> > WDYT?
>
> I like this! I hope we do not add too much redundant work, but at least we
> make it clear what is the plan to fix this in the future.
Please approve the PR again, so that I could merge this after I give some time
for others to look at this.
Xazax-hun wrote:
> WDYT?
I like this! I hope we do not add too much redundant work, but at least we make
it clear what is the plan to fix this in the future.
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> Hmm, I wonder if we should leave a FIXME comment, but it looks good to me.
I was thinking where to put the FIXME, and as I explored that should be within
the CastVisitor. After that, I argued, that then I should still have the
(ineffective) `SVB.evalCast()` to actually
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/70837
>From a7f64815f4986fad597b9cb2d1acce2de9ac20bf Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Mon, 23 Oct 2023 18:10:29 +0200
Subject: [PATCH 1/2] [analyzer] Fix assertion failure in
Xazax-hun wrote:
Hmm, I wonder if we should leave a FIXME comment, but it looks good to me.
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/70837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
Workaround the case when the `this` pointer is actually a `NonLoc`, by
returning `Unknown` instead.
The solution isn't ideal, as `this` should be really a `Loc`, but due to how
casts
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/70837
Workaround the case when the `this` pointer is actually a `NonLoc`, by
returning `Unknown` instead.
The solution isn't ideal, as `this` should be really a `Loc`, but due to how
casts work, I feel this is our
20 matches
Mail list logo
