=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
The issue was really trivial to fix, I created a PR for it:
https://github.com/llvm/llvm-project/pull/75216
Sorry for breaking check-clang, I _did_ ran the tests before pressing merge on
the github GU
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
nico wrote:
This breaks check-clang everywhere, e.g.:
https://lab.llvm.org/buildbot/#/builders/139/builds/55404
http://45.33.8.238/linux/125647/step_7.txt
Please take a look and revert for now if it takes a while to fix
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE closed
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
Sounds good!
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
The limitation is emphasized in the documentation, and I also added a `TODO`
comment that mentions it in the source code.
I'll merge this change as it is now (because I don't want to leave it open for
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67157
>From 5c42d3e5286e041e22776fa496d884454640ffec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Fri, 22 Sep 2023 17
Xazax-hun wrote:
I am a bit concerned about the bad user experience with bitwise enums, but I
think that is probably OK since this is an optin check. That being said, I
think:
* It would be easy to address this, there is already a clang tidy check for
bitwise enums, the heuristics to recognize
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
PR https://github.com/llvm/llvm-project/pull/74503 was merged, so I think all
the review comments are addressed. @haoNoQ @Xazax-hun What do you think about
merging this?
https://github.com/llvm/llvm-project/pull/67157
___
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
DonatNagyE wrote:
> > Before merging this PR, the diagnostics of the EnumCast checker should be
> > updated to mention the name of the `enum` type in question. @gamesh411
> > could you create a PR that implements this improvement (as we discuss
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> (Force pushed the branch because I wanted to rebase it onto a recent main and
> fix the merge conflicts. Is there a better workflow than this?)
I think git also offers conflict resolution for `git merge origin/main`. It
shoul
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67157
>From 5c42d3e5286e041e22776fa496d884454640ffec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Fri, 22 Sep 2023 17:22:53 +0200
Subject: [PA
DonatNagyE wrote:
(Force pushed the branch because I wanted to rebase it onto a recent main and
fix the merge conflicts. Is there a better workflow than this?)
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@li
https://github.com/DonatNagyE updated
https://github.com/llvm/llvm-project/pull/67157
>From 5c42d3e5286e041e22776fa496d884454640ffec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Fri, 22 Sep 2023 17:22:53 +0200
Subject: [PATCH] [analyzer] Move alpha checker EnumCastOutOfRan
DonatNagyE wrote:
@Xazax-hun This checker doesn't accept the use of bitwise enums (like the one
in your example), so projects that use bitwise enums should not enable this
checker. (Perhaps this limitation should be mentioned in the docs? @gamesh411)
It would be possible to write a more comple
Xazax-hun wrote:
How well does this check work with bitwise enums?
People often write code like:
```
enum AnimalFlags
{
HasClaws = 1,
CanFly = 2,
EatsFish = 4,
Endangered = 8
};
AnimalFlags operator|(AnimalFlags a, AnimalFlags b)
{
return static_cast(static_cast(a)
haoNoQ wrote:
> Before merging this PR, the diagnostics of the EnumCast checker should be
> updated to mention the name of the `enum` type in question. @gamesh411 could
> you create a PR that implements this improvement (as we discussed)?
Yes, it should call out the enum, call out the value, a
DonatNagyE wrote:
Before merging this PR, the diagnostics of the EnumCast checker should be
updated to mention the name of the `enum` type in question. @gamesh411 could
you create a PR that implements this improvement (as we discussed)?
https://github.com/llvm/llvm-project/pull/67157
_
https://github.com/gamesh411 approved this pull request.
https://github.com/llvm/llvm-project/pull/67157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gamesh411 wrote:
| OpenSource Project name | New Reports | Reports Lost | Evaluation of reports |
|||||
| memcached_1.6.8 | [New
reports](https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?run=memcached_1.6.8_baseline&newcheck=memcached_1.6.8_with_
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
The checker EnumCastOutOfRange verifies the (helpful, but not
standard-mandated) design rule that integer to enum casts should not produce
values that don't have a corresponding enumerator. As it was improved and
cleaned up by recent chan
https://github.com/DonatNagyE created
https://github.com/llvm/llvm-project/pull/67157
The checker EnumCastOutOfRange verifies the (helpful, but not
standard-mandated) design rule that integer to enum casts should not produce
values that don't have a corresponding enumerator. As it was improved
22 matches
Mail list logo
