https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/4] [analyzer] Turn NodeBuilderContext into a class
---
diego-est wrote:
Seems like it wasn't as easy as just making them private. I think I found all
the places where there were private member accesses. The tests passed on my
side again and the github-pull-requests action. The code_formatter action keeps
failing because of the documentation on
@@ -194,11 +194,12 @@ class CoreEngine {
};
// TODO: Turn into a class.
diego-est wrote:
Done.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4fdf10faf2b45f4bbbd2ddfb07272d19a47cc531
0d4adf0600c1a86b092fec52749bd781e0ecfd6d --
https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/3] [analyzer] Turn NodeBuilderContext into a class
---
@@ -194,11 +194,12 @@ class CoreEngine {
};
// TODO: Turn into a class.
steakhal wrote:
Remove this TODO, as its completed.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
https://github.com/steakhal commented:
Alright. So we can simply mark all the members private. I was surprised a bit.
LGTM, but remove the TODO comment you fix.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
diego-est wrote:
I added the appropriate functions and moved the class members into private.
Additionally I ran `make check-all` to make sure the now-private members
wouldn't cause any issues with the rest of the codebase, all the checks passed.
https://github.com/llvm/llvm-project/pull/84638
https://github.com/diego-est updated
https://github.com/llvm/llvm-project/pull/84638
>From 114e22388508cd1ef5174bdda041564691b58032 Mon Sep 17 00:00:00 2001
From: Sunglas
Date: Sat, 9 Mar 2024 12:23:43 -0400
Subject: [PATCH 1/2] [analyzer] Turn NodeBuilderContext into a class
---
https://github.com/steakhal requested changes to this pull request.
See my previous reply.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal wrote:
Thanks for the PR.
I think it would make sense to not expose data members in a class' public api.
We might need some member functions along the way to make this possible.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Diego A. Estrada Rivera (diego-est)
Changes
>From issue #73088. I changed `NodeBuilderContext` into a class.
>Additionally, there were some other mentions of the former being a struct
>which I
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/diego-est created
https://github.com/llvm/llvm-project/pull/84638
>From issue #73088. I changed `NodeBuilderContext` into a class. Additionally,
>there were some other mentions of the former being a struct which I also
>changed into a class. This is my first time working
15 matches
Mail list logo
