https://github.com/domin144 closed
https://github.com/llvm/llvm-project/pull/81474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
domin144 wrote:
@mplatings Can you merge for me? I don't have needed rights.
I rebased hoping the check will pass now, but there are still some unrelated
failures on windows.
https://github.com/llvm/llvm-project/pull/81474
___
cfe-commits mailing
https://github.com/domin144 updated
https://github.com/llvm/llvm-project/pull/81474
From 4eda12594dbc07e3d3509a309d6691dcc983e5cc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20W=C3=B3jt?=
Date: Mon, 12 Feb 2024 13:38:14 +0100
Subject: [PATCH 1/3] [clang][AArch64] multilib: fix deduction
Dominik =?utf-8?q?W=C3=B3jt?= ,
Dominik =?utf-8?q?W=C3=B3jt?=
Message-ID:
In-Reply-To:
https://github.com/mplatings approved this pull request.
https://github.com/llvm/llvm-project/pull/81474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -191,7 +191,11 @@ static void getAArch64MultilibFlags(const Driver ,
for (const auto : AArch64::Extensions)
if (FeatureSet.contains(Ext.NegFeature))
MArch.push_back(("no" + Ext.Name).str());
- MArch.insert(MArch.begin(), ("-march=" +
https://github.com/domin144 updated
https://github.com/llvm/llvm-project/pull/81474
From da3ef3a5705ca4eec5683e0c048dd93da8c58b5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20W=C3=B3jt?=
Date: Mon, 12 Feb 2024 13:38:14 +0100
Subject: [PATCH 1/3] [clang][AArch64] multilib: fix deduction
Dominik =?utf-8?q?W=C3=B3jt?=
Message-ID:
In-Reply-To:
https://github.com/mplatings requested changes to this pull request.
Definitely an improvement, thanks.
https://github.com/llvm/llvm-project/pull/81474
___
cfe-commits mailing list
Dominik =?utf-8?q?Wójt?=
Message-ID:
In-Reply-To:
@@ -191,7 +191,11 @@ static void getAArch64MultilibFlags(const Driver ,
for (const auto : AArch64::Extensions)
if (FeatureSet.contains(Ext.NegFeature))
MArch.push_back(("no" + Ext.Name).str());
-
Dominik =?utf-8?q?Wójt?=
Message-ID:
In-Reply-To:
https://github.com/mplatings edited
https://github.com/llvm/llvm-project/pull/81474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
domin144 wrote:
@MaskRay @petrhosek @smithp35 @mplatings
Looking at previous reviews for multilib related changes you might be
interested.
(ingore the buildkite failure for now. It seems unrelated.)
https://github.com/llvm/llvm-project/pull/81474
https://github.com/domin144 updated
https://github.com/llvm/llvm-project/pull/81474
From e25d580c7297071f067200639d8b8fe3be74eec6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20W=C3=B3jt?=
Date: Mon, 12 Feb 2024 13:38:14 +0100
Subject: [PATCH 1/2] [clang][AArch64] multilib: fix deduction
https://github.com/domin144 updated
https://github.com/llvm/llvm-project/pull/81474
From 9ffef2685c2766c6944e368a739b8c94e9b68092 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20W=C3=B3jt?=
Date: Mon, 12 Feb 2024 13:38:14 +0100
Subject: [PATCH 1/2] [clang][AArch64] multilib: fix deduction
https://github.com/domin144 updated
https://github.com/llvm/llvm-project/pull/81474
From 8f8d2b304aa90c0aea00d67e86d285ecd870e443 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20W=C3=B3jt?=
Date: Mon, 12 Feb 2024 13:38:14 +0100
Subject: [PATCH 1/2] [clang][AArch64] multilib: fix deduction
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dominik Wójt (domin144)
Changes
The deduced "-march=" option always started with aarch64, which is not a valid
value. There was also no way to distinguish between armv8-r and armv8-a. After
this commit, the deduced "-march=" option will
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Dominik Wójt (domin144)
Changes
The deduced "-march=" option always started with aarch64, which is not a valid
value. There was also no way to distinguish between armv8-r and armv8-a. After
this commit, the deduced "-march="
https://github.com/domin144 created
https://github.com/llvm/llvm-project/pull/81474
The deduced "-march=" option always started with aarch64, which is not a valid
value. There was also no way to distinguish between armv8-r and armv8-a. After
this commit, the deduced "-march=" option will
16 matches
Mail list logo
