https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/76226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
jcsxky wrote:
revert
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 77976022454865df8bee1e4a09682a16658ed035 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
balazske wrote:
I see now that the old code was better, there
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
jcsxky wrote:
Done.
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From ab1ace9573588153f1e8caf992a6abda3322c6a7 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
@@ -1491,6 +1492,12 @@ static bool
IsRecordContextStructurallyEquivalent(RecordDecl *D1,
return false;
}
+if (auto *D1Spec = dyn_cast(DC1)) {
+ auto *D2Spec = dyn_cast(DC2);
balazske wrote:
It would be better to check if `D2Spec` is
https://github.com/DonatNagyE approved this pull request.
https://github.com/llvm/llvm-project/pull/76226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 77976022454865df8bee1e4a09682a16658ed035 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 27005dba5f7530143657c514250a362670e3d67d Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 574fa37117614fc4e23c12a7ecd297304d5eb337 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From be62fb62934052db668eea57a9ff241fcd06cd2c Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 9a8cea81eba77eef914089e3cffd96e863aac36f Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/76226
>From 08a2bb64e19fe244361cb58a1e8eed64a2c1f0cd Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Fri, 22 Dec 2023 17:56:32 +0800
Subject: [PATCH] [clang][ASTImporter][StructuralEquivalence] improve
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/76226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
Types comparison in `StructuralEquivalence` ignores its `DeclContext` when they
are generated by template specialization implicitly and this will produce
incorrect result. Add comparison of `DeclContext` of
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/76226
Types comparison in `StructuralEquivalence` ignores its `DeclContext` when they
are generated by template specialization implicitly and this will produce
incorrect result. Add comparison of `DeclContext` of
17 matches
Mail list logo
