[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-31 Thread Shafik Yaghmour via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -6397,116 +6400,132 @@ ExpectedDecl ASTNodeImporter::VisitVarTemplateSpecializationDecl( // Try to find an existing specialization with these template arguments. void *InsertPos = nullptr; -

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-31 Thread Shafik Yaghmour via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -6397,116 +6400,132 @@ ExpectedDecl ASTNodeImporter::VisitVarTemplateSpecializationDecl( // Try to find an existing specialization with these template arguments. void *InsertPos = nullptr; -

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/78284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-26 Thread Qizhi Hu via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/jcsxky approved this pull request. https://github.com/llvm/llvm-project/pull/78284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-26 Thread Qizhi Hu via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: jcsxky wrote: I have tested the code locally and testcase from this [issue](https://github.com/llvm/llvm-project/issues/75114) and all works fine. So, I approve this patch. https://github.com/llvm/llvm-project/pull/78284

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/78284 From 41393908cb142f5b863a7a4203d89a57c5ce4bc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 22 Nov 2023 16:33:58 +0100 Subject: [PATCH 1/2] [clang][ASTImporter] Improve import of

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-16 Thread Balázs Kéri via cfe-commits
balazske wrote: After this change it should be possible to add a ``` static bool IsStructurallyEquivalent(StructuralEquivalenceContext , VarTemplateDecl *D1, VarTemplateDecl *D2) ``` function with all tests passing.

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 28bad76e34441a3a43f4bf32e028b43fad93 41393908cb142f5b863a7a4203d89a57c5ce4bc1 --

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes Code of `VisitVarTemplateSpecializationDecl` was rewritten based on code of `VisitVarDecl`. Additional changes (in structural equivalence) were made to make tests pass. --- Patch is 22.77 KiB, truncated

[clang] [clang][ASTImporter] Improve import of variable template specializations. (PR #78284)

2024-01-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/78284 Code of `VisitVarTemplateSpecializationDecl` was rewritten based on code of `VisitVarDecl`. Additional changes (in structural equivalence) were made to make tests pass. From