[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

HighCommander4 wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/86466 >From 73d2082c164ba629babec3cc3dc9b1d06b41ec60 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Mon, 25 Mar 2024 02:14:00 -0400 Subject: [PATCH] [clang][CodeComplete] Handle deref operator in

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

@@ -5674,6 +5675,11 @@ QualType getApproximateType(const Expr *E) { return getApproximateType(VD->getInit()); } } + if (const auto *UO = llvm::dyn_cast(E)) { +if (UO->getOpcode() == UnaryOperatorKind::UO_Deref) { zyn0217 wrote: nit: We

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

https://github.com/zyn0217 approved this pull request. Thanks. LGTM apart from one nit. https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes This allows completing after `(*this).` in a dependent context. Fixes https://github.com/clangd/clangd/issues/1952 --- Full diff: https://github.com/llvm/llvm-project/pull/86466.diff 2 Files

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/86466 This allows completing after `(*this).` in a dependent context. Fixes https://github.com/clangd/clangd/issues/1952 >From 6cac58d2e5c3c7effc0f0cc01c1368b9ddd6c21a Mon Sep 17 00:00:00 2001 From: Nathan