https://github.com/DimitryAndric updated
https://github.com/llvm/llvm-project/pull/75935
>From 4b3db6bdaf9f94277f23bf9a796f474a353e4d73 Mon Sep 17 00:00:00 2001
From: Dimitry Andric
Date: Tue, 19 Dec 2023 13:37:37 +0100
Subject: [PATCH] [clang] Add getClangVendor() and use it in
https://github.com/petrhosek requested changes to this pull request.
I agree with @smeenai, we shouldn't be setting `CLANG_VENDOR` as a global
define.
https://github.com/llvm/llvm-project/pull/75935
___
cfe-commits mailing list
https://github.com/ysyeda approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/75935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai requested changes to this pull request.
IIRC, applying definitions like this only to a small set of files was an
intentional decision, to minimize rebuilding when their values changed. It
matters much more for the commit hash than the vendor, but passing defines like
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Dimitry Andric (DimitryAndric)
Changes
In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is supposed
to be a string, as it is defined
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dimitry Andric (DimitryAndric)
Changes
In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is supposed
to be a string, as it is defined (optionally)
https://github.com/DimitryAndric created
https://github.com/llvm/llvm-project/pull/75935
In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is supposed
to be a string, as it is defined (optionally) as such
