[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-25 Thread Björn Pettersson via cfe-commits
https://github.com/bjope closed https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-25 Thread Björn Pettersson via cfe-commits
https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/65624 From caa626ea4e813c7061b44f6b4336f31fce511f4b Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Thu, 7 Sep 2023 13:08:22 +0200 Subject: [PATCH] [clang][CodeGen] Simplify code based on opaque pointers - Update

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-14 Thread Björn Pettersson via cfe-commits
https://github.com/bjope resolved https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-14 Thread Björn Pettersson via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; bjope wrote: Ok , thanks. Then I assume the name is

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes - Update CodeGenTypeCache to use a single union for all pointers in address space zero. - Introduce a UnqualPtrTy in CodeGenTypeCache, and use that (for example instead of llvm::PointerType::getUnqual) in some places. - Drop

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-14 Thread Björn Pettersson via cfe-commits
https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/65624: From 6ccf70a6aa245b83667ef6547c869035dd06da6f Mon Sep 17 00:00:00 2001 From: Bjorn Pettersson Date: Thu, 7 Sep 2023 13:08:22 +0200 Subject: [PATCH] [clang][CodeGen] Simplify code based on opaque pointers -

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Jessica Clarke via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; jrtc27 wrote: (Presumably the IR type's nomenclature

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Jessica Clarke via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; jrtc27 wrote: Not qualified (c.f. QualType)

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
@@ -51,14 +51,11 @@ struct CodeGenTypeCache { llvm::IntegerType *PtrDiffTy; }; - /// void* in address space 0 + /// void*, void** in address space 0 union { +llvm::PointerType *UnqualPtrTy; bjope wrote: Maybe `OpaquePtrTy` is a better name.

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread via cfe-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope review_requested https://github.com/llvm/llvm-project/pull/65624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Simplify code based on opaque pointers (PR #65624)

2023-09-07 Thread Björn Pettersson via cfe-commits
https://github.com/bjope created https://github.com/llvm/llvm-project/pull/65624: - Update CodeGenTypeCache to use a single union for all pointers in address space zero. - Introduce a UnqualPtrTy in CodeGenTypeCache, and use that (for example instead of llvm::PointerType::getUnqual) in some