[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris closed https://github.com/llvm/llvm-project/pull/77829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris updated https://github.com/llvm/llvm-project/pull/77829 >From f626b1f4ca2a6fd2b6c5eea3b53c15c4502d29fa Mon Sep 17 00:00:00 2001 From: Matthew Voss Date: Thu, 11 Jan 2024 12:18:03 -0800 Subject: [PATCH] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris updated https://github.com/llvm/llvm-project/pull/77829 >From b8d3ec5cde2b311747aec83d316af370202b37c1 Mon Sep 17 00:00:00 2001 From: Matthew Voss Date: Thu, 11 Jan 2024 12:18:03 -0800 Subject: [PATCH] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
ormris wrote: Thanks! I'll make sure to include that review in the commit message. Unified LTO is using the ThinLTO pre-link pipeline, regardless of what's passed to the driver. Since the ThinLTO pre-link pipeline doesn't provide this pass, this option should be required when Unified LTO is us

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Fangrui Song via cfe-commits
MaskRay wrote: The description should mention https://reviews.llvm.org/D153583 ("[ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin"). I think this is correct when used in the ThinLTO mode, but it's not clear whether regular LTO mode is correct. https://github.com/llvm/llvm-proje

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/77829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2bb511e277e501d3faa0f2da0d1c98ea0b515507 4f3d4470b696bd4eeb5a59105b4cd5ee741a818f --

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Matthew Voss (ormris) Changes Unified LTO and Fat LTO do not use the regular LTO prelink pipeline when -flto/-flto=full is specified on the command line, thus they require LowerMatrixIntrinsicsPass to be run during the link stage.

[clang] [clang][FatLTO][UnifiedLTO] Pass -enable-matrix to the LTO driver (PR #77829)

2024-01-11 Thread Matthew Voss via cfe-commits
https://github.com/ormris created https://github.com/llvm/llvm-project/pull/77829 Unified LTO and Fat LTO do not use the regular LTO prelink pipeline when -flto/-flto=full is specified on the command line, thus they require LowerMatrixIntrinsicsPass to be run during the link stage. To enable t