https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/68222
>From 8022677bd92d4074ccaebda687f43066ce33d152 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 4 Oct 2023 10:06:28 -0400
Subject: [PATCH 1/2] [clang][Index] Use canonical function parameter types
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/68222
>From 8022677bd92d4074ccaebda687f43066ce33d152 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 4 Oct 2023 10:06:28 -0400
Subject: [PATCH] [clang][Index] Use canonical function parameter types in
sdkrystian wrote:
@mizvekov I totally forgot about this PR, sorry! I'll add a test and merge
tomorrow :)
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
mizvekov wrote:
@sdkrystian ping, do you still intend to continue this? Just adding your
example as a test case would be fine.
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
sdkrystian wrote:
@mizvekov Sure, I'll take care of that tomorrow
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
Also, would you make sure to add a test case for this?
Thanks.
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/68222
>From db0887d6c68dc5610a9189c96de8fcbb631385a1 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 4 Oct 2023 10:06:28 -0400
Subject: [PATCH] [clang][Index] Use canonical function parameter types in
@@ -265,10 +265,13 @@ void USRGenerator::VisitFunctionDecl(const FunctionDecl
*D) {
Out << '>';
}
+ QualType CanonicalType = D->getType().getCanonicalType();
// Mangle in type information for the arguments.
- for (auto *PD : D->parameters()) {
-Out << '#';
-
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/68222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/68222
This is necessary to ensure that functions declared in different translation
units whose parameter types only differ in top-level cv-qualification generate
the same USR.
For example:
```cpp
// A.cpp
void f(
11 matches
Mail list logo