[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-21 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/79753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-20 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/79753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/79753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-13 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/79753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-02-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79753 >From 0e108e92b3165f95a934895e14f6c330f6c5e3fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 16:13:08 +0100 Subject: [PATCH] [clang][Interp] Emit const references for Float

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
tbaederr wrote: For reference, the generated code with this patch looks like this: ```c++ #if defined(GET_EVAL_PROTO) || defined(GET_LINK_PROTO) bool emitConstFloat(const Floating &, const SourceInfo &); #endif #ifdef GET_LINK_IMPL bool ByteCodeEmitter::emitConstFloat(const Floating &A0, const S

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The Float print type is backed by the Floating class, which in turn uses APFloat, which might heap-allocate memory, so might be expensive to copy. Add an 'AsRef' bit to the ArgType tablegen class, which defi

[clang] [clang][Interp] Emit const references for Float arguments (PR #79753)

2024-01-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79753 The Float print type is backed by the Floating class, which in turn uses APFloat, which might heap-allocate memory, so might be expensive to copy. Add an 'AsRef' bit to the ArgType tablegen class, which defines