[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/67900 >From b5e64ac8d36fef66cb8ef698f74997616d2957bc Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct `Module:

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

cor3ntin wrote: @davidstone ping https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

ChuanqiXu9 wrote: > Would someone be able to merge this for me? I do not have permission. Sorry for not merging this in time. Could you rebase again since it has conflicts now. https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing l

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

davidstone wrote: Would someone be able to merge this for me? I do not have permission. https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67900 >From b5e64ac8d36fef66cb8ef698f74997616d2957bc Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct `Modul

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/dwblaikie approved this pull request. Awesome - love a good readability improvement. Thanks! https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

davidstone wrote: @ChuanqiXu9 https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67900 >From 858a76e16a772078b29452645c5beb223c06dc8e Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct `Modul

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67900 >From 0253be550776631980d77e7847c6337786d64911 Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct `Modul

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e7247f1010b546ca4d98a6ee40414d2d1cae0381 0253be550776631980d77e7847c6337786d64911 --

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

llvmbot wrote: @llvm/pr-subscribers-clang Changes `Module::Requirement` was defined as a `std::pair`. This required a comment to explain what the data members mean and makes the usage harder to understand. Replace this with a struct with two members, `FeatureName` and

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/davidstone created https://github.com/llvm/llvm-project/pull/67900 `Module::Requirement` was defined as a `std::pair`. This required a comment to explain what the data members mean and makes the usage harder to understand. Replace this with a struct with two members, `Featu