@@ -1444,7 +1444,7 @@ struct PragmaWarningHandler : public PragmaHandler {
.Case("once", PPCallbacks::PWS_Once)
.Case("suppress", PPCallbacks::PWS_Suppress)
.Default(-1);
-
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I think CI is having some difficulties. No need to wait for it for this.
Thanks a lot for your first contribution!
We have some good first issues if you want to have a go at some more
contributions
shafik wrote:
The `amdgpu-toolchain.c` test failure looks unrelated. I think we need another
empty commit to kick off the build again unfortunately.
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9cbf96ad5b6fe777bf5acd43b65abfb062381f8c
db61b6d6e2c5ff75ffcf43874bfed60243e4e671 --
https://github.com/Troy-Butler updated
https://github.com/llvm/llvm-project/pull/89923
>From cde48906d4b9a08dc436ab94f183c124ee336e5a Mon Sep 17 00:00:00 2001
From: Troy-Butler
Date: Wed, 24 Apr 2024 09:23:29 -0400
Subject: [PATCH 1/3] [clang][Lex] Reformat suspicious condition
Signed-off-by:
https://github.com/Troy-Butler updated
https://github.com/llvm/llvm-project/pull/89923
>From cde48906d4b9a08dc436ab94f183c124ee336e5a Mon Sep 17 00:00:00 2001
From: Troy-Butler
Date: Wed, 24 Apr 2024 09:23:29 -0400
Subject: [PATCH 1/2] [clang][Lex] Reformat suspicious condition
Signed-off-by:
AaronBallman wrote:
> I see that the build has failed - what do I need to do to fix this?
That build failure looks unrelated to your changes, I think it just got caught
in a bad state. You can try pushing no changes to the branch to kick off a new
build just to be sure, though.
Troy-Butler wrote:
I see that the build has failed - what do I need to do to fix this?
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
This makes sense, I added Nico since they added the change that brought in that
line.
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Troy-Butler wrote:
> Thanks for your contribution. Will you need me to merge that for you?
Yes please! I don't have merging rights. Thank you!
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Thanks for your contribution.
Will you need me to merge that for you?
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
14 matches
Mail list logo
