Keenuts wrote:
Thanks all!
Agree with Bogner, let's unblock the tests first.
As for the address space for globals, this isn't something we have looked into
yet, so I'd be in favor of keeping the same behavior as the SPIRN flavor until
we have a reason to diverge (as in "thought about this
https://github.com/coopp commented:
Looks good
https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bogner wrote:
> a) Thanks!; b) apologies for the noise; c) this was actually done on purpose,
> I actively eschewed changing Logical SPIRV because it wasn't actually clear
> to me if in the long run it'd have the same AS map / would use numerical 1
> for globals. If Logical SPIRV is going to
https://github.com/AlexVlx approved this pull request.
LGTM, please have a peek at the comment if possible.
https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AlexVlx wrote:
a) Thanks!; b) apologies for the noise; c) this was actually done on purpose, I
actively eschewed changing Logical SPIRV because it wasn't actually clear to me
if in the long run it'd have the same AS map / would use numerical 1 for
globals. If Logical SPIRV is going to go with
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Justin Bogner (bogner)
Changes
This was missed in #88455, causing most of the .hlsl to SPIR-V tests to
fail (such as clang\test\Driver\hlsl-lang-targets-spirv.hlsl)
---
Full diff: https://github.com/llvm/llvm-project/pull/88939.diff
1
