@@ -379,6 +379,18 @@ namespace dr1347 { // dr1347: 3.1
#endif
}
+namespace dr1351 { // dr1351: 1
Endilll wrote:
I guess you intended `// dr1351: 18`.
https://github.com/llvm/llvm-project/pull/76248
___
cfe-commits
https://github.com/Endilll requested changes to this pull request.
You need to run `clang/www/make_cxx_drs` script in order to make
`cxx_dr_status.html` reflect that CWG1351 is now implemented.
https://github.com/llvm/llvm-project/pull/76248
___
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/76248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Lancern updated
https://github.com/llvm/llvm-project/pull/76248
>From c219e38a7953b5bd494554760043053ae3b8ff60 Mon Sep 17 00:00:00 2001
From: Sirui Mu
Date: Sat, 23 Dec 2023 00:02:08 +0800
Subject: [PATCH 1/5] [clang][Sema] deleted overriding function can have lax
except
https://github.com/erichkeane commented:
This needs a release note. Also, since this is implementing a core issue, this
needs to update a DRs test as well.
https://github.com/llvm/llvm-project/pull/76248
___
cfe-commits mailing list
https://github.com/Lancern updated
https://github.com/llvm/llvm-project/pull/76248
>From c219e38a7953b5bd494554760043053ae3b8ff60 Mon Sep 17 00:00:00 2001
From: Sirui Mu
Date: Sat, 23 Dec 2023 00:02:08 +0800
Subject: [PATCH 1/4] [clang][Sema] deleted overriding function can have lax
except
Lancern wrote:
Oops, code formatter formats unrelated code. Revert and re-commit.
https://github.com/llvm/llvm-project/pull/76248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Lancern updated
https://github.com/llvm/llvm-project/pull/76248
>From c219e38a7953b5bd494554760043053ae3b8ff60 Mon Sep 17 00:00:00 2001
From: Sirui Mu
Date: Sat, 23 Dec 2023 00:02:08 +0800
Subject: [PATCH 1/2] [clang][Sema] deleted overriding function can have lax
except
@@ -979,6 +979,11 @@ bool Sema::CheckOverridingFunctionExceptionSpec(const
CXXMethodDecl *New,
if (isa(New) && New->getParent()->isDependentType())
return false;
+ // CWG1351: if either of the old function or the new function is defined as
+ // deleted, we don't need
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sirui Mu (Lancern)
Changes
According to [CWG1351](https://cplusplus.github.io/CWG/issues/1351.html),
overriding functions that are defined as deleted can have more lax exception
specifications compared to the base version. For example,
https://github.com/Lancern created
https://github.com/llvm/llvm-project/pull/76248
According to [CWG1351](https://cplusplus.github.io/CWG/issues/1351.html),
overriding functions that are defined as deleted can have more lax exception
specifications compared to the base version. For example,
11 matches
Mail list logo
