https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/70540
>From e89412b0a67927145f49d9cc53562eed77989f99 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Tue, 31 Oct 2023 13:05:19 +0800
Subject: [PATCH] [clang][analyzer] Update CallDescription of 'tmpfile' &
'fopen' in
benshi001 wrote:
> I would like to have the new test in `stream.c` (not `stream.cpp`) because
> the C++ test file contains only C++ related StreamChecker tests (`tmpfile`
> belongs not here). And a "FIXME" could be added to the test to indicate that
> this is a faulty behavior (in the current
https://github.com/benshi001 updated
https://github.com/llvm/llvm-project/pull/70540
>From 73d6ce1980fcbb1869b1be522adda6ab5af8a385 Mon Sep 17 00:00:00 2001
From: Ben Shi
Date: Tue, 31 Oct 2023 13:05:19 +0800
Subject: [PATCH] [clang][analyzer] Update CallDescription of 'tmpfile' in
benshi001 wrote:
> I would like to have the new test in `stream.c` (not `stream.cpp`) because
> the C++ test file contains only C++ related StreamChecker tests (`tmpfile`
> belongs not here). And a "FIXME" could be added to the test to indicate that
> this is a faulty behavior (in the current
https://github.com/steakhal approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/70540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
balazske wrote:
I would like to have the new test in `stream.c` (not `stream.cpp`) because the
C++ test file contains only C++ related StreamChecker tests (`tmpfile` belongs
not here). And a "FIXME" could be added to the test to indicate that this is a
faulty behavior (in the current case).
benshi001 wrote:
> The change is good but the title is too general, better is for example
> "Update CallDescription in StreamChecker for `tmpfile`", and this is not a
> NFC (it fixes a problem).
Thanks for your reply. I changed this PR to a pure test supplement. And I will
create another PR
https://github.com/benshi001 edited
https://github.com/llvm/llvm-project/pull/70540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
