[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/NagyDonat approved this pull request. LGTM, thanks for the update! https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -313,6 +232,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/83288 From f5aeb6e97e73d317d55189c656c31a84757f9636 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 28 Feb 2024 17:51:29 +0100 Subject: [PATCH 1/2] [clang][analyzer] Add StreamChecker

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

@@ -313,6 +232,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

@@ -218,87 +218,6 @@ inline void assertStreamStateOpened(const StreamState *SS) { assert(SS->isOpened() && "Stream is expected to be opened"); } -struct StreamOperationEvaluator { balazske wrote: There should be something that is used from `StreamChecker`

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

@@ -218,87 +218,6 @@ inline void assertStreamStateOpened(const StreamState *SS) { assert(SS->isOpened() && "Stream is expected to be opened"); } -struct StreamOperationEvaluator { NagyDonat wrote: Why are you moving the definition of this struct? (Feel

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/NagyDonat approved this pull request. The change looks reasonable, I only have minor remarks. Re: your question about changing the warning message, I think that removing the single quotes around 'indeterminate' is probably a good idea, but the current message is also OK.

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

@@ -607,6 +564,103 @@ class StreamChecker : public Checkerget(StreamSym); +if (!SS) + return false; +NewES = SS->ErrorState; +CE = dyn_cast_or_null(Call.getOriginExpr()); +if (!CE) + return false; + +assertStreamStateOpened(SS); + +return true; +

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

@@ -313,6 +232,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

balazske wrote: fixed formatting errors https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/83288 From f5aeb6e97e73d317d55189c656c31a84757f9636 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 28 Feb 2024 17:51:29 +0100 Subject: [PATCH] [clang][analyzer] Add StreamChecker note

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

balazske wrote: Related to this, I want to change text "File position of the stream might be 'indeterminate'" to something better, or maybe only remove the `'` characters from it. https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9e1432069555d70e1f0148742e565b31d3ba8695 0d8b058dd8de3b29888f76554fca2d920410a4d7 --

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes If a stream operation fails the position can become "indeterminate". This may cause warning from the checker at a later operation. The new note tag shows the place where the position becomes

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

https://github.com/balazske created https://github.com/llvm/llvm-project/pull/83288 If a stream operation fails the position can become "indeterminate". This may cause warning from the checker at a later operation. The new note tag shows the place where the position becomes "indeterminate",