[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Ben Shi via cfe-commits
benshi001 wrote: > No release notes? I have created another PR to add the miss release note. https://github.com/llvm/llvm-project/pull/76805 https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Ben Shi via cfe-commits
benshi001 wrote: > No release notes? Sorry, I forget to pull your modification to my local repo, I will fix this soon. https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Balazs Benics via cfe-commits
steakhal wrote: No release notes? https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Ben Shi via cfe-commits
https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. LGTM (if the tests pass) https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Ben Shi via cfe-commits
@@ -2511,10 +2511,12 @@ void StdLibraryFunctionsChecker::initFunctionSummaries( .ArgConstraint(NotNull(ArgNo(0; // char *mkdtemp(char *template); -// FIXME: Improve for errno modeling. addToFunctionSummaryMap( "mkdtemp",

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/76671 >From 0c586914ac977920140472d172ee357dea43f2c5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 1 Jan 2024 18:48:27 +0800 Subject: [PATCH 1/2] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' ---

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Balázs Kéri via cfe-commits
@@ -54,3 +51,25 @@ int errno_lseek(int fildes, off_t offset) { } return 0; } + +void errno_mkstemp(char *template) { + int FD = mkstemp(template); + if (FD >= 0) { +if (errno) {}// expected-warning{{An undefined value may be read from 'errno'}} +

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-03 Thread Balázs Kéri via cfe-commits
@@ -2511,10 +2511,12 @@ void StdLibraryFunctionsChecker::initFunctionSummaries( .ArgConstraint(NotNull(ArgNo(0; // char *mkdtemp(char *template); -// FIXME: Improve for errno modeling. addToFunctionSummaryMap( "mkdtemp",

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Ben Shi via cfe-commits
benshi001 wrote: > LGTM Thanks for your help! https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/76671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/76671 >From 0c586914ac977920140472d172ee357dea43f2c5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 1 Jan 2024 18:48:27 +0800 Subject: [PATCH 1/2] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' ---

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/76671 >From 0c586914ac977920140472d172ee357dea43f2c5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 1 Jan 2024 18:48:27 +0800 Subject: [PATCH] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' ---

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/76671.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp (+4-2) - (modified)

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/76671.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp (+4-2) - (modified)

[clang] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' (PR #76671)

2024-01-01 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/76671 None >From e776bdf419556917463a1fdc978fac8fd8b89aaf Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 1 Jan 2024 18:48:27 +0800 Subject: [PATCH] [clang][analyzer] Improve 'errno' modeling of 'mkdtemp' ---