martinboehme wrote:
> @bazuzi and @martinboehme this change seems to be causing a test failure on
> many bots. Can you take a look and revert if you need time to investigate?
>
> * https://lab.llvm.org/buildbot/#/builders/139/builds/54773
> * https://lab.llvm.org/buildbot/#/builders/216/builds/
jayfoad wrote:
Hi, on my Release+Asserts build this is causing:
```
FAIL: Clang-Unit ::
Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/32/38 (134 of 658)
TEST 'Clang-Unit ::
Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/32/38' FAILED
**
dyung wrote:
@bazuzi and @martinboehme this change seems to be causing a test failure on
many bots. Can you take a look and revert if you need time to investigate?
- https://lab.llvm.org/buildbot/#/builders/139/builds/54773
- https://lab.llvm.org/buildbot/#/builders/216/builds/31319
- https://
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bazuzi wrote:
Can you merge for me, now that I've finally remembered to format everything?
https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/bazuzi updated
https://github.com/llvm/llvm-project/pull/73978
>From aab1069636896c4a8289545ba01d2fdf4f1715c0 Mon Sep 17 00:00:00 2001
From: Samira Bazuzi
Date: Thu, 30 Nov 2023 14:18:04 -0500
Subject: [PATCH 1/4] [clang][dataflow] Retrieve members from accessors called
usin
https://github.com/bazuzi updated
https://github.com/llvm/llvm-project/pull/73978
>From aab1069636896c4a8289545ba01d2fdf4f1715c0 Mon Sep 17 00:00:00 2001
From: Samira Bazuzi
Date: Thu, 30 Nov 2023 14:18:04 -0500
Subject: [PATCH 1/3] [clang][dataflow] Retrieve members from accessors called
usin
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ff485a0e77a55847cb50768b01c04fe45a6879ea
120bdd51496dd69c601181bccae072effb547920 --
https://github.com/bazuzi updated
https://github.com/llvm/llvm-project/pull/73978
>From aab1069636896c4a8289545ba01d2fdf4f1715c0 Mon Sep 17 00:00:00 2001
From: Samira Bazuzi
Date: Thu, 30 Nov 2023 14:18:04 -0500
Subject: [PATCH 1/2] [clang][dataflow] Retrieve members from accessors called
usin
@@ -300,9 +300,10 @@ static void insertIfFunction(const Decl &D,
}
static MemberExpr *getMemberForAccessor(const CXXMemberCallExpr &C) {
- if (!C.getMethodDecl())
+ const auto *MethodDecl = dyn_cast_or_null(C.getCalleeDecl());
bazuzi wrote:
Done
https://gi
@@ -300,9 +300,10 @@ static void insertIfFunction(const Decl &D,
}
static MemberExpr *getMemberForAccessor(const CXXMemberCallExpr &C) {
- if (!C.getMethodDecl())
+ const auto *MethodDecl = dyn_cast_or_null(C.getCalleeDecl());
ymand wrote:
Please add a comm
https://github.com/ymand approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ymand wrote:
> @ymand Can you review?
sure
https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bazuzi wrote:
@ymand Can you review?
https://github.com/llvm/llvm-project/pull/73978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Samira Bazuzi (bazuzi)
Changes
… pointers.
getMethodDecl does not handle pointers to members and returns nullptr for them.
getMethodDecl contains a decade-plus-old FIXME to handle pointers to members,
but two approaches I looked
16 matches
Mail list logo
