https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/70144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
> Yeah. I did try to fix up all calls to LookupFile to perform module map
> lookup, but a bunch of tests started failing (mostly standard C++ modules
> tests IIRC), so there's probably more nuance required there.
Okay, I do think this
jansvoboda11 wrote:
> Can you clarify how this bug occurs in terms of what information about the
> header is stored that causes us to get the wrong module?
I updated the test case to be more in line with how the bug manifested in the
wild. Let me annotate the test case here to hopefully
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/70144
>From 4199b80e5cb0a8873f63c356e4c4304833d6fffa Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 24 Oct 2023 16:30:22 -0700
Subject: [PATCH 1/2] [clang][deps] Fix `__has_include` behavior with umbrella
https://github.com/benlangmuir commented:
Can you clarify how this bug occurs in terms of what information about the
header is stored that causes us to get the wrong module? It seems bad that
passing `nullptr` to `LookupFile` could cause incorrect behaviour and makes me
wonder if we need to
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/70144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/70144
Previously, Clang wouldn't try to resolve the module for the header being
checked via `__has_include`. This meant that such header was considered textual
(a.k.a. part of the module Clang is currently
