[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/DavidTruby closed https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

banach-space wrote: > I've left the flang test as the flang directory doesn't change with > `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` and removed the other test. I hope this > is what you meant @MaskRay  That's matches how I read that suggestion re `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR`, thanks!

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

DavidTruby wrote: I've left the flang test as the flang directory doesn't change with `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` and removed the other test. I hope this is what you meant @MaskRay  https://github.com/llvm/llvm-project/pull/90758 ___

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/90758 >From 9763281019c1fb27714243450d7a6879e91dcb28 Mon Sep 17 00:00:00 2001 From: David Truby Date: Wed, 1 May 2024 19:41:47 +0100 Subject: [PATCH 1/3] [clang][flang][windows] Prefer user-provided library paths

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

DavidTruby wrote: > The code checks whether the directory is present `auto CRTPath = > TC.getCompilerRTPath();` and only adds the libpath when it is present. This > is related to the `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off` file hierarchy we > are migrating way from. > > With

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

MaskRay wrote: The code checks whether the directory is present `auto CRTPath = TC.getCompilerRTPath();` and only adds the libpath when it is present. This is related to the `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off` file hierarchy we are migrating way from. With

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

@@ -0,0 +1,7 @@ +// REQUIRES: system-windows MaskRay wrote: Add tests to existing msvc-link.c instead of a new file. Specify `--target=` to avoid reliance on the default target triple and avoid the need of REQUIRES.

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/MaskRay requested changes to this pull request. 。 https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

@@ -0,0 +1,8 @@ +! REQUIRES: system-windows +! +! RUN: %clang --driver-mode=flang -### %s -Ltest 2>&1 | FileCheck %s banach-space wrote: [nit] `test` -> `random_test_dir` or something else that will make this stand out a bit more (makes parsing tests a bit

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

@@ -0,0 +1,8 @@ +! REQUIRES: system-windows +! +! RUN: %clang --driver-mode=flang -### %s -Ltest 2>&1 | FileCheck %s +! +! Test that user provided paths come before the Flang runtimes and compiler-rt +! CHECK: "-libpath:test" banach-space wrote: Wondering how to

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/banach-space approved this pull request. LGTM, thanks! I've left some nits, feel free to ignore https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/90758 >From 0afdbb7dac3a3a051661d5747c8c6470a13f1e0c Mon Sep 17 00:00:00 2001 From: David Truby Date: Wed, 1 May 2024 19:41:47 +0100 Subject: [PATCH 1/2] [clang][flang][windows] Prefer user-provided library paths

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

MaskRay wrote: Thanks. Can you add a test? Possibly `clang/test/Driver/msvc-link.c`. `linux-cross.cpp` has a good example about how to test the default `-L` paths. https://github.com/llvm/llvm-project/pull/90758 ___ cfe-commits mailing list

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

llvmbot wrote: @llvm/pr-subscribers-clang Author: David Truby (DavidTruby) Changes Currently the paths to compiler-rt and the Flang runtimes from the LLVM build/install directory are preferred over any user-provided library paths. This means a user can't override compiler-rt or the

[clang] [clang][flang][windows] Prefer user-provided library paths (-L) (PR #90758)

https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/90758 Currently the paths to compiler-rt and the Flang runtimes from the LLVM build/install directory are preferred over any user-provided library paths. This means a user can't override compiler-rt or the Flang