[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

abrachet wrote: No, feel free to commandeer this patch https://github.com/llvm/llvm-project/pull/67376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

erichkeane wrote: > So it looks like this breaks the ast-dump-attr.cpp test, so that needs fixing. > > Also, there is quite a bit of changes happening around the SemaDeclAttr.cpp > changes by @AaronBallman, so the two need to be merged in some way. "Merged" could be: 1-rebased on the other, bu

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -2352,26 +2352,37 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } +template +static void handleCtorDtorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + uint32_t priority = Attr::Defaul

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -5661,10 +5662,20 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, setNonAliasAttributes(GD, Fn); SetLLVMFunctionAttributesForDefinition(D, Fn); - if (const ConstructorAttr *CA = D->getAttr()) -AddGlobalCtor(Fn, CA->getPriority()); + auto getPri

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -1422,9 +1424,11 @@ def Deprecated : InheritableAttr { def Destructor : InheritableAttr { let Spellings = [GCC<"destructor">]; - let Args = [DefaultIntArgument<"Priority", 65535>]; + let Args = [ExprArgument<"Priority", 1>]; let Subjects = SubjectList<[Function]>;

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/erichkeane commented: So it looks like this breaks the ast-dump-attr.cpp test, so that needs fixing. Also, there is quite a bit of changes happening around the SemaDeclAttr.cpp changes by @AaronBallman, so the two need to be merged in some way. https://github.com/llvm/llvm-p

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -10,3 +13,14 @@ struct Foo { bar(); } }; + +template erichkeane wrote: Please write a test where the argument is NTTP dependent on another template argument. https://github.com/llvm/llvm-project/pull/67376 __

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -1156,9 +1156,11 @@ def ConstInit : InheritableAttr { def Constructor : InheritableAttr { let Spellings = [GCC<"constructor">]; - let Args = [DefaultIntArgument<"Priority", 65535>]; + let Args = [ExprArgument<"Priority", 1>]; let Subjects = SubjectList<[Function]>;

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/67376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes Fixes #67154 --- Full diff: https://github.com/llvm/llvm-project/pull/67376.diff 6 Files Affected: - (modified) clang/include/clang/Basic/Attr.td (+6-2) - (modified) clang/lib/CodeGen/CodeGenModule.cpp (+14-3) - (modified) clan

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/67376 Fixes #67154 >From 5317e66d8997c0406994809901429d5a88c0e0c6 Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Mon, 25 Sep 2023 17:35:13 -0400 Subject: [PATCH] [clang] All {con,de}structor attributes to use temp