[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

felipepiovezan wrote: If this gets reverted for some reason, please note that I had to update a cross-project-tests test: https://github.com/llvm/llvm-project/pull/73566 https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

serge-sans-paille wrote: > @serge-sans-paille those test failures were also highlighted by the precommit > checks, would be good to check those before landing I did validate locally, but I forgot I had some targets disabled :-/ https://github.com/llvm/llvm-project/pull/71677

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

fhahn wrote: @serge-sans-paille those test failures were also highlighted by the precommit checks, would be good to check those before landing https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

fhahn wrote: Reverted the change for now, as many build bots have been red due to the test failures https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

JOE1994 wrote: FYI, the following `clang` tests seem to fail after revision [fe5c360](https://github.com/llvm/llvm-project/commit/fe5c360a9aae61db37886c0c795c409b5129905f) ``` Failed Tests (2): Clang :: CodeGen/aapcs-align.cpp Clang :: CodeGen/aapcs64-align.cpp ```

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

serge-sans-paille wrote: @omjavaid thanks for the revert. Life was in the way today and I couldn't handle that properly. The patch was trivial, I'm going to recommit soon. https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

omjavaid wrote: This change appears to have broken several clang tests on following buildbots: https://lab.llvm.org/buildbot/#/builders/245 https://lab.llvm.org/buildbot/#/builders/188 https://lab.llvm.org/buildbot/#/builders/186 https://lab.llvm.org/buildbot/#/builders/183 Kindly fix issues if

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

serge-sans-paille wrote: @efriedma-quic : gentle ping :-) https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/71677 >From d5934a4112166ce0375295b2347e7d5c43fdf5ed Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH 1/4] [clang] Avoid memcopy for small structure with

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1506,8 +1497,16 @@ TEST_CUSTOM(unmatchedreverse, unmatchedreverse, { .c = 42 }); // CHECK-O0:call void @llvm.memcpy // CHECK-NOT: !annotation // CHECK-O0:call void @{{.*}}used{{.*}}%custom) -// PATTERN-O1: store i32 -1431655894, ptr {{.*}}, align 4 -//

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule , const VarDecl , // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case when

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1506,8 +1497,16 @@ TEST_CUSTOM(unmatchedreverse, unmatchedreverse, { .c = 42 }); // CHECK-O0:call void @llvm.memcpy // CHECK-NOT: !annotation // CHECK-O0:call void @{{.*}}used{{.*}}%custom) -// PATTERN-O1: store i32 -1431655894, ptr {{.*}}, align 4 -//

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule , const VarDecl , // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case when

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule , const VarDecl , // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case when

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule , const VarDecl , // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case when

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/71677 >From d5934a4112166ce0375295b2347e7d5c43fdf5ed Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Wed, 8 Nov 2023 10:26:33 +0100 Subject: [PATCH 1/3] [clang] Avoid memcopy for small structure with

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule , const VarDecl , // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case when

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/serge-sans-paille edited https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits