[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

hokein wrote: > LGTM, interesting it looks like we don't do this check in fromContraintExpr > either. Yes, I think it is an oversight, we should do the check for it as well. https://github.com/llvm/llvm-project/pull/86869 ___ cfe-commits mailing

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/86869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/86869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/shafik approved this pull request. LGTM, interesting it looks like we don't do this check in `fromContraintExpr` either. https://github.com/llvm/llvm-project/pull/86869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/zyn0217 approved this pull request. Thanks! This reminds me that I should also check the validity of InstantiatingTemplate after introducing a new CodeSynthesisContext in my patch of fixing lambda calls within type alias decls.

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

Sirraide wrote: Side note: Now it’s starting to make sense why something like an unknown include was triggering this otherwise entirely unrelated failure: The first thing that the constructor of `InstantiatingTemplate` does is bail out if there was a fatal error.

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/86869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Fixes #86757 We missed to handle the invalid case when substituting into the parameter mapping of an constraint during normalization. --- Full diff: https://github.com/llvm/llvm-project/pull/86869.diff 3

[clang] [clang] Bailout when the substitution of template parameter mapping is invalid. (PR #86869)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/86869 Fixes #86757 We missed to handle the invalid case when substituting into the parameter mapping of an constraint during normalization. >From 85eba887cf6d253ff041b23cd4d8d5506aa1c674 Mon Sep 17 00:00:00 2001